Merge pull request #157 from hyperion-ml/persephone-refactor

debug gmm

Author: jesus-villalba

hyperion/np/pdfs/mixtures/exp_family_mixture.py

@@ -105,12 +105,6 @@ def fit(
                 )
                 elbo_val[epoch] = self.elbo(None, N=N, u_x=u_x, log_h=log_h_val)
 
-            print(
-                elbo[epoch] / x.shape[0],
-                np.mean(self.log_prob(x, mode="nat")),
-                np.mean(self.log_prob(x, mode="std")),
-            )
-
         if x_val is None:
             return elbo, elbo / x.shape[0]
         else:

hyperion/np/pdfs/mixtures/gmm_diag_cov.py

@@ -180,9 +180,9 @@ def Mstep(self, N, u_x):
 
         if self.update_Lambda:
             S = S / N[:, None] - self.mu**2
-            # S_floor = self.var_floor * np.mean(S[N > self.min_N], axis=0)
-            # S_floor = np.maximum(S_floor, 1e-10)
-            # S = np.maximum(S, S_floor)
+            S_floor = self.var_floor * np.mean(S[N > self.min_N], axis=0)
+            S_floor = np.maximum(S_floor, 1e-10)
+            S = np.maximum(S, S_floor)
             self.Lambda = 1 / S
             self._Sigma = S
             self._cholLambda = None