Skip to content

Upgrade dependencies. Migrate to Kodein 7 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 28, 2020

Conversation

yamidragut
Copy link
Contributor

PR's key points

Upgrade the dependencies and migrate to Kodein 7. Check specially KodeinAndroidUtils
Pending to do:
- Fix the typed viewmodels in KodeinAndroidUtils

Definition of Done

  • Tests pass
  • Works with Proguard
  • There is no outcommented or debug code left

@yamidragut yamidragut requested a review from adriangl as a code owner December 15, 2020 14:35
yamidragut and others added 7 commits December 28, 2020 08:30
Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
…droidUtils.kt

Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
…droidUtils.kt

Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
…droidUtils.kt

Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
@yamidragut yamidragut requested a review from adriangl December 28, 2020 07:54
@adriangl adriangl merged commit 15343f4 into hyperdevs-team:master Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants