-
Notifications
You must be signed in to change notification settings - Fork 5
Upgrade dependencies. Migrate to Kodein 7 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
adriangl
merged 8 commits into
hyperdevs-team:master
from
yamidragut:upgrade-dependencies
Dec 28, 2020
Merged
Upgrade dependencies. Migrate to Kodein 7 #15
adriangl
merged 8 commits into
hyperdevs-team:master
from
yamidragut:upgrade-dependencies
Dec 28, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangl
requested changes
Dec 26, 2020
mini-kodein-android/src/main/java/mini/kodein/android/KodeinAndroidUtils.kt
Outdated
Show resolved
Hide resolved
mini-kodein-android/src/main/java/mini/kodein/android/KodeinAndroidUtils.kt
Outdated
Show resolved
Hide resolved
mini-kodein-android/src/main/java/mini/kodein/android/KodeinAndroidUtils.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
…droidUtils.kt Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
…droidUtils.kt Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
…droidUtils.kt Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
Co-authored-by: Adrián García <adriangarcia.lopez@gmail.com>
adriangl
approved these changes
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR's key points
Upgrade the dependencies and migrate to Kodein 7. Check specially
KodeinAndroidUtils
Pending to do:
- Fix the typed viewmodels in
KodeinAndroidUtils
Definition of Done