Skip to content

fix: check for presence of metadata.allowlist instead of allowlist #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

Jipperism
Copy link
Contributor

reverts a regression introduced in commit
4f6beba where we started checking for allowlist, instead of metadata.allowlist. We should actually check for the presence of metadata.allowlist, to prevent the case where the user specifies both a CID and a json allowlist to the endpoint.

reverts a regression introduced in commit
4f6beba where we started checking for
allowlist, instead of metadata.allowlist. We should actually check for
the presence of metadata.allowlist, to prevent the case where the user
specifies both a CID and a json allowlist to the endpoint.
Copy link

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 20.86% (🎯 20%) 858 / 4113
🟢 Statements 20.86% (🎯 20%) 858 / 4113
🟢 Functions 52.85% (🎯 52%) 37 / 70
🟢 Branches 67.96% (🎯 63%) 140 / 206
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/controllers/MetadataController.ts 41.37% 72.72% 50% 41.37% 61-73, 116-180, 214-228, 237-244, 261-308
Generated in workflow #39 for commit 61ac0c3 by the Vitest Coverage Report Action

@Jipperism
Copy link
Contributor Author

Closes hypercerts-org/hypercerts-app#360

@Jipperism Jipperism requested a review from bitbeckers January 30, 2025 16:04
@bitbeckers bitbeckers added the bug Something isn't working label Jan 30, 2025
@bitbeckers bitbeckers merged commit de2ef0e into develop Jan 30, 2025
1 check passed
@Jipperism Jipperism deleted the bugfix/409-422-with-allowlist branch May 17, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

[bug] error 409 and 422
2 participants