-
Notifications
You must be signed in to change notification settings - Fork 65
Add sktime detector integration #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…rOptCv, tests, example and CI
|
@fkiraly @SimonBlanke please review this pr. Thanks! |
fkiraly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks nice, but it feels like your are trying to import an evaluate function which does not exist, from sktime.
Currently there is no evaluate for detectors in sktime, so you may have to write it first there! Metrics and estimator API already exists, and imo it should be similar to forecasting. I would suggest you open an issue in sktime to add the evaluate method for detectors if it dtoes not exist, and add the routine there.
|
@arnavk23, can you describe how this is integrated with |
The mentioned PR in this pull request needs to merged first in sktime. |
|
code quality checks are failing - please use |
Made the changes. Please see. |
SktimeDetectorExperimentand a wrapper estimatorTSDetectorOptCvso Hyperactive optimizers can tune sktime detectors with the same workflow used for classifiers/forecasters.sktimedetectors integration #197