Skip to content

Commit 9a6b40d

Browse files
committed
Merge pull request #5 from dscsolutions/FixBadRevert
Fix bad revert
2 parents a07c992 + 97007ce commit 9a6b40d

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

src/ServiceManagement/Compute/Commands.ServiceManagement.Test/UnitTests/Cmdlets/IaaS/Extensions/DSC/GetAzureVMDscExtensionStatusUnitTest.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,17 +25,17 @@ public void TestGetService()
2525
{
2626
//when service name is passed as argument in the cmdlet
2727
getAzureVmDscExtensionStatusCmdlet.GetService(ServiceName, null);
28-
Assert.Equal(ServiceName, getAzureVmDscExtensionStatusCmdlet.Service);
28+
Assert.Equal(ServiceName, getAzureVmDscExtensionStatusCmdlet.ServiceName);
2929

3030
//when vm object is passed as argument in the cmdlet
3131
getAzureVmDscExtensionStatusCmdlet.GetService("", GetAzureVM(ServiceName, ServiceName));
32-
Assert.Equal(ServiceName, getAzureVmDscExtensionStatusCmdlet.Service);
32+
Assert.Equal(ServiceName, getAzureVmDscExtensionStatusCmdlet.ServiceName);
3333
}
3434

3535
[Fact]
3636
public void TestGetVirtualMachineDscStatusContextListWithServiceName()
3737
{
38-
getAzureVmDscExtensionStatusCmdlet.Service = ServiceName;
38+
getAzureVmDscExtensionStatusCmdlet.ServiceName = ServiceName;
3939

4040
// service has multiple vm's
4141
var roles = new List<NSM.Role> {CreateRole("dscmachine01"), CreateRole("dscmachine02")};
@@ -59,7 +59,7 @@ public void TestGetVirtualMachineDscStatusContextListWithServiceName()
5959
[Fact]
6060
public void TestGetVirtualMachineDscStatusContextListWithServiceNameAndVmName()
6161
{
62-
getAzureVmDscExtensionStatusCmdlet.Service = ServiceName;
62+
getAzureVmDscExtensionStatusCmdlet.ServiceName = ServiceName;
6363
getAzureVmDscExtensionStatusCmdlet.Name = "dscmachine01";
6464

6565
// service has multiple vm's
@@ -84,7 +84,7 @@ public void TestGetVirtualMachineDscStatusContextListWithServiceNameAndVmName()
8484
[Fact]
8585
public void TestGetVirtualMachineDscStatusContextListWithServiceNameAndIncorrectVmName()
8686
{
87-
getAzureVmDscExtensionStatusCmdlet.Service = ServiceName;
87+
getAzureVmDscExtensionStatusCmdlet.ServiceName = ServiceName;
8888
getAzureVmDscExtensionStatusCmdlet.Name = "some-blah";
8989

9090
// service has multiple vm's
@@ -108,7 +108,7 @@ public void TestGetVirtualMachineDscStatusContextListWithServiceNameAndIncorrect
108108
[Fact]
109109
public void TestGetVirtualMachineDscStatusContextListWithVm()
110110
{
111-
getAzureVmDscExtensionStatusCmdlet.Service = ServiceName;
111+
getAzureVmDscExtensionStatusCmdlet.ServiceName = ServiceName;
112112
getAzureVmDscExtensionStatusCmdlet.VmName = "dscmachine02";
113113

114114
// service has multiple vm's
@@ -127,7 +127,7 @@ public void TestGetVirtualMachineDscStatusContextListWithVm()
127127
[Fact]
128128
public void TestCreateDscStatusContext()
129129
{
130-
getAzureVmDscExtensionStatusCmdlet.Service = ServiceName;
130+
getAzureVmDscExtensionStatusCmdlet.ServiceName = ServiceName;
131131

132132
var roles = new List<NSM.Role> {CreateRole("dscmachine02")};
133133
var roleInstances = new List<NSM.RoleInstance> {CreateRoleInstance("dscmachine02")};

src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/Extensions/DSC/GetAzureVMDscExtensionStatus.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ public class GetAzureVmDscExtensionStatusCommand : IaaSDeploymentManagementCmdle
8383
protected const string GetStatusByServiceAndVmNameParamSet = "GetStatusByServiceAndVMName";
8484
protected const string GetStatusByVmParamSet = "GetStatusByVM";
8585

86-
internal string Service;
8786
internal string VmName;
8887

8988
/// <summary>
@@ -94,6 +93,7 @@ protected override void ExecuteCommand()
9493
{
9594
ServiceManagementProfile.Initialize();
9695
GetService(ServiceName, VM);
96+
9797
base.ExecuteCommand();
9898

9999
if (CurrentDeploymentNewSM == null)
@@ -118,7 +118,7 @@ internal void GetService(String serviceName, IPersistentVM vm)
118118
{
119119
if (!string.IsNullOrEmpty(serviceName))
120120
{
121-
Service = serviceName;
121+
this.ServiceName = serviceName;
122122
}
123123
else
124124
{
@@ -127,7 +127,7 @@ internal void GetService(String serviceName, IPersistentVM vm)
127127
if (vmRoleContext == null)
128128
return;
129129

130-
Service = vmRoleContext.ServiceName;
130+
this.ServiceName = vmRoleContext.ServiceName;
131131
VmName = vmRoleContext.Name;
132132
}
133133
}
@@ -207,7 +207,7 @@ internal VirtualMachineDscExtensionStatusContext CreateDscStatusContext(NSM.Role
207207

208208
var dscStatusContext = new VirtualMachineDscExtensionStatusContext
209209
{
210-
ServiceName = Service,
210+
ServiceName = this.ServiceName,
211211
Name = vmRole == null ? string.Empty : vmRole.RoleName,
212212
Status = extensionSettingStatus.Status ?? string.Empty,
213213
StatusCode = extensionSettingStatus.Code ?? -1,

0 commit comments

Comments
 (0)