From f00397506bfb597772b87b1446828771c466a725 Mon Sep 17 00:00:00 2001 From: kmarshall Date: Tue, 16 Aug 2016 14:45:00 -0700 Subject: [PATCH] Disable zlib compression in Blimp until crbug.com/637376 fixed. There is a compiler/code optimization bug in zlib's SIMD implementation, which will take time to investigate and fix. This CL restores functionality in Blimp by disabling compression. This CL can be rolled back once the root cause of crbug.com/637736 is addressed. R=lethalantidote@chromium.org CC=wez@chromium.org BUG=637376 Review-Url: https://codereview.chromium.org/2248943003 Cr-Commit-Position: refs/heads/master@{#412346} --- blimp/net/stream_socket_connection.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/blimp/net/stream_socket_connection.cc b/blimp/net/stream_socket_connection.cc index bd0fad651ca114..9faa2011a43293 100644 --- a/blimp/net/stream_socket_connection.cc +++ b/blimp/net/stream_socket_connection.cc @@ -14,12 +14,12 @@ namespace blimp { +// TODO(kmarshall): Re-enable CompressedPacket(Reader|Writer) +// after zlib bug in crbug.com/r637376 is resolved. StreamSocketConnection::StreamSocketConnection( std::unique_ptr socket) - : BlimpConnection(base::MakeUnique( - base::MakeUnique(socket.get())), - base::MakeUnique( - base::MakeUnique(socket.get()))), + : BlimpConnection(base::MakeUnique(socket.get()), + base::MakeUnique(socket.get())), socket_(std::move(socket)) { DCHECK(socket_); }