Remove the temporary scaffolding stubs.

They have served they purpose well, but now it's time to retire. It's one of the things that draggen in the bad dependency of chrome/common on chrome/browser, and is sufficiently small now to stub things out individually. TEST=none BUG=none Review URL: http://codereview.chromium.org/593037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38639 0039d316-1c4b-4281-b951-d872f2087c98
hylschwy · Feb 10, 2010 · e06131d · e06131d
1 parent ef12239
commit e06131d
Show file tree

Hide file tree

Showing 26 changed files with 303 additions and 278 deletions.
diff --git a/chrome/PRESUBMIT.py b/chrome/PRESUBMIT.py
@@ -36,7 +36,6 @@
   r'bloom_filter\.cc$',
   # Bogus ifdef tricks
   r'renderer_webkitclient_impl\.cc$',
-  r'temp_scaffolding_stubs\.h$',
   # Lines > 100 chars
   r'gcapi\.cc$',
 )

diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
@@ -44,7 +44,6 @@
 #include "chrome/common/pref_names.h"
 #include "chrome/common/pref_service.h"
 #include "chrome/browser/profile_manager.h"
-#include "chrome/common/temp_scaffolding_stubs.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "net/base/net_util.h"

diff --git a/chrome/browser/automation/automation_provider_mac.mm b/chrome/browser/automation/automation_provider_mac.mm
@@ -16,8 +16,8 @@
   if (window) {
     NSRect new_bounds = NSRectFromCGRect(bounds.ToCGRect());
 
-    // This is likely incorrect for a multiple-monitor setup; OK because this is
-    // used only for testing purposes.
+    // This is likely incorrect for a multiple-monitor setup; OK because this
+    // is used only for testing purposes.
     new_bounds.origin.y = [[window screen] frame].size.height -
         new_bounds.origin.y - new_bounds.size.height;
 
@@ -67,6 +67,45 @@
   NOTIMPLEMENTED();
 }
 
+void AutomationProvider::GetAutocompleteEditText(
+    int autocomplete_edit_handle, bool* success, std::wstring* text) {
+  *success = false;
+  NOTIMPLEMENTED();
+}
+
+void AutomationProvider::SetAutocompleteEditText(int autocomplete_edit_handle,
+                                                 const std::wstring& text,
+                                                 bool* success) {
+  *success = false;
+  NOTIMPLEMENTED();
+}
+
+void AutomationProvider::AutocompleteEditIsQueryInProgress(
+    int autocomplete_edit_handle, bool* success, bool* query_in_progress) {
+  *success = false;
+  NOTIMPLEMENTED();
+}
+
+void AutomationProvider::AutocompleteEditGetMatches(
+    int autocomplete_edit_handle, bool* success,
+    std::vector<AutocompleteMatchData>* matches) {
+  *success = false;
+  NOTIMPLEMENTED();
+}
+
+void AutomationProvider::OnMessageFromExternalHost(int handle,
+                                                   const std::string& message,
+                                                   const std::string& origin,
+                                                   const std::string& target) {
+  NOTIMPLEMENTED();
+}
+
+void AutomationProvider::GetAutocompleteEditForBrowser(
+    int browser_handle, bool* success, int* autocomplete_edit_handle) {
+  *success = false;
+  NOTIMPLEMENTED();
+}
+
 void AutomationProvider::SetInitialFocus(const IPC::Message& message,
                                          int handle, bool reverse) {
   NOTIMPLEMENTED();

diff --git a/chrome/browser/bookmarks/bookmark_drag_data.h b/chrome/browser/bookmarks/bookmark_drag_data.h
@@ -12,11 +12,8 @@
 #include "base/string16.h"
 #include "googleurl/src/gurl.h"
 
-// TODO(port): Port this file.
 #if defined(TOOLKIT_VIEWS)
 #include "app/os_exchange_data.h"
-#else
-#include "chrome/common/temp_scaffolding_stubs.h"
 #endif
 
 class BookmarkModel;

diff --git a/chrome/browser/browser.cc b/chrome/browser/browser.cc
@@ -27,6 +27,7 @@
 #include "chrome/browser/character_encoding.h"
 #include "chrome/browser/debugger/devtools_manager.h"
 #include "chrome/browser/debugger/devtools_window.h"
+#include "chrome/browser/dock_info.h"
 #include "chrome/browser/dom_ui/filebrowse_ui.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "chrome/browser/download/download_manager.h"
@@ -100,10 +101,6 @@
 #include "chrome/common/child_process_host.h"
 #endif  // OS_WIN
 
-#if !defined(OS_MACOSX)
-#include "chrome/browser/dock_info.h"
-#endif
-
 #if defined(OS_MACOSX)
 #include "chrome/browser/cocoa/find_pasteboard.h"
 #endif

diff --git a/chrome/browser/browser_list_gtk.cc b/chrome/browser/browser_list_gtk.cc
@@ -6,6 +6,7 @@
 
 #include <gtk/gtk.h>
 
+// static
 void BrowserList::AllBrowsersClosed() {
   // Close non-browser windows.
   GList* window_list = gtk_window_list_toplevels();

diff --git a/chrome/browser/browser_list_stub.cc b/chrome/browser/browser_list_stub.cc
@@ -0,0 +1,9 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/browser_list.h"
+
+// static
+void BrowserList::AllBrowsersClosed() {
+}
diff --git a/chrome/browser/browser_list_win.cc b/chrome/browser/browser_list_win.cc
@@ -0,0 +1,12 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/browser_list.h"
+
+#include "views/window/window.h"
+
+// static
+void BrowserList::AllBrowsersClosed() {
+  views::Window::CloseAllSecondaryWindows();
+}
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
@@ -30,6 +30,7 @@
 #include "chrome/browser/net/sqlite_persistent_cookie_store.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/plugin_service.h"
+#include "chrome/browser/printing/print_job_manager.h"
 #include "chrome/browser/profile_manager.h"
 #include "chrome/browser/renderer_host/render_process_host.h"
 #include "chrome/browser/renderer_host/resource_dispatcher_host.h"
@@ -50,13 +51,6 @@
 #include "views/focus/view_storage.h"
 #endif
 
-#if defined(OS_LINUX)
-// TODO(port): get rid of this.
-#include "chrome/common/temp_scaffolding_stubs.h"
-#else
-#include "chrome/browser/printing/print_job_manager.h"
-#endif
-
 #if defined(IPC_MESSAGE_LOG_ENABLED)
 #include "chrome/common/plugin_messages.h"
 #include "chrome/common/render_messages.h"

diff --git a/chrome/browser/cocoa/browser_window_cocoa.mm b/chrome/browser/cocoa/browser_window_cocoa.mm
@@ -33,7 +33,6 @@
 #include "chrome/common/notification_service.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/pref_service.h"
-#include "chrome/common/temp_scaffolding_stubs.h"
 #include "chrome/browser/profile.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"

diff --git a/chrome/browser/cocoa/font_language_settings_controller.mm b/chrome/browser/cocoa/font_language_settings_controller.mm
@@ -8,6 +8,7 @@
 #import "base/mac_util.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/character_encoding.h"
+#include "chrome/browser/fonts_languages_window.h"
 #include "chrome/browser/profile.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/pref_service.h"
@@ -16,6 +17,12 @@
 NSString* const kCharacterInfoName = @"name";
 NSString* const kCharacterInfoID = @"id";
 
+void ShowFontsLanguagesWindow(gfx::NativeWindow window,
+                              FontsLanguagesPage page,
+                              Profile* profile) {
+  NOTIMPLEMENTED();
+}
+
 @interface FontLanguageSettingsController (Private)
 - (void)updateDisplayField:(NSTextField*)field withFont:(NSFont*)font;
 @end

diff --git a/chrome/browser/dock_info_mac.cc b/chrome/browser/dock_info_mac.cc
@@ -0,0 +1,17 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/dock_info.h"
+
+#include "base/logging.h"
+
+bool DockInfo::GetNewWindowBounds(gfx::Rect* new_window_bounds,
+                                  bool* maximize_new_window) const {
+  // TODO(pinkerton): Implement DockInfo, http://crbug.com/9274.
+  return true;
+}
+
+void DockInfo::AdjustOtherWindowBounds() const {
+  // TODO(pinkerton): Implement DockInfo, http://crbug.com/9274.
+}
diff --git a/chrome/browser/jankometer_mac.cc b/chrome/browser/jankometer_mac.cc
@@ -0,0 +1,13 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/jankometer.h"
+
+void InstallJankometer(const CommandLine& parsed_command_line) {
+  // TODO(port): Implement jankometer, http://crbug.com/8077
+}
+
+void UninstallJankometer() {
+  // TODO(port): Implement jankometer, http://crbug.com/8077
+}
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
@@ -190,10 +190,8 @@
 #include "base/rand_util.h"
 #endif
 
-#if defined(OS_POSIX)
-// TODO(port): Move these headers above as they are ported.
-#include "chrome/common/temp_scaffolding_stubs.h"
-#else
+// TODO(port): port browser_distribution.h.
+#if !defined(OS_POSIX)
 #include "chrome/installer/util/browser_distribution.h"
 #endif
 

diff --git a/chrome/browser/printing/print_job_linux.cc b/chrome/browser/printing/print_job_linux.cc
@@ -0,0 +1,17 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/printing/print_job.h"
+
+#include "base/logging.h"
+#include "chrome/browser/printing/print_job_worker.h"
+#include "printing/printed_document.h"
+
+namespace printing {
+
+PrintJob::PrintJob() : ui_message_loop_(NULL) {
+  NOTIMPLEMENTED();
+}
+
+}  // namespace printing
diff --git a/chrome/browser/printing/print_job_manager_linux.cc b/chrome/browser/printing/print_job_manager_linux.cc
@@ -0,0 +1,41 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/printing/print_job_manager.h"
+
+#include "base/logging.h"
+#include "chrome/browser/printing/print_job.h"
+#include "chrome/browser/printing/printer_query.h"
+#include "chrome/common/notification_type.h"
+
+namespace printing {
+
+PrintJobManager::PrintJobManager() {
+  NOTIMPLEMENTED();
+}
+
+PrintJobManager::~PrintJobManager() {
+  NOTIMPLEMENTED();
+}
+
+void PrintJobManager::OnQuit() {
+  NOTIMPLEMENTED();
+}
+
+void PrintJobManager::QueuePrinterQuery(PrinterQuery* job) {
+  NOTIMPLEMENTED();
+}
+
+void PrintJobManager::PopPrinterQuery(int document_cookie,
+                                      scoped_refptr<PrinterQuery>* job) {
+  NOTIMPLEMENTED();
+}
+
+void PrintJobManager::Observe(NotificationType type,
+                              const NotificationSource& source,
+                              const NotificationDetails& details) {
+  NOTIMPLEMENTED();
+}
+
+}  // namespace printing
diff --git a/chrome/browser/printing/print_view_manager_linux.cc b/chrome/browser/printing/print_view_manager_linux.cc
@@ -0,0 +1,58 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/printing/print_view_manager.h"
+
+#include <string>
+
+#include "base/logging.h"
+#include "googleurl/src/gurl.h"
+#include "chrome/browser/printing/print_job.h"
+#include "chrome/common/notification_type.h"
+
+namespace printing {
+
+PrintViewManager::PrintViewManager(TabContents& owner) : owner_(owner) {
+  NOTIMPLEMENTED();
+}
+
+PrintViewManager::~PrintViewManager() {
+  NOTIMPLEMENTED();
+}
+
+void PrintViewManager::Stop() {
+  NOTIMPLEMENTED();
+}
+
+bool PrintViewManager::OnRenderViewGone(RenderViewHost* render_view_host) {
+  NOTIMPLEMENTED();
+  return true;
+}
+
+std::wstring PrintViewManager::RenderSourceName() {
+  NOTIMPLEMENTED();
+  return std::wstring();
+}
+
+GURL PrintViewManager::RenderSourceUrl() {
+  NOTIMPLEMENTED();
+  return GURL();
+}
+
+void PrintViewManager::DidGetPrintedPagesCount(int cookie, int number_pages) {
+  NOTIMPLEMENTED();
+}
+
+void PrintViewManager::DidPrintPage(
+    const ViewHostMsg_DidPrintPage_Params& params) {
+  NOTIMPLEMENTED();
+}
+
+void PrintViewManager::Observe(NotificationType type,
+                               const NotificationSource& source,
+                               const NotificationDetails& details) {
+  NOTIMPLEMENTED();
+}
+
+}  // namespace printing