From d9ab67759f6cd14a7f323a2134b6982f2dc7ed10 Mon Sep 17 00:00:00 2001 From: avi Date: Mon, 22 Sep 2014 08:49:49 -0700 Subject: [PATCH] Revert of [Mac] Remove unnecessary button on 'Bookmark all tabs' window (patchset #2 id:20001 of https://codereview.chromium.org/583633002/) Reason for revert: Nonono you can't just hack out lines from xib files! https://codereview.chromium.org/586543002/ rebuilds the xib file in Xcode to accomplish this and more. Original issue's description: > [Mac] Remove unnecessary button on 'Bookmark all tabs' window > > Remove unnecessary button on 'Bookmark all tabs' window which appears > before "Bookmarks Bar" > XIB Changes: > Removing the line in the following .xib file which is responsible for the appearance of empty button. > chrome/app/nibs/BookmarkAllTabs.xib > > BUG=415554 > R=asvitkine@chromium.org > > TEST= > 1) Launch chrome, open 2-3 tabs. > 2) Right click on last tab and select 'Bookmark all tabs' > 3) Empty button shouldn't be shown. > > Committed: https://crrev.com/0ce925fc1ee0f53142313d1b63b32dafbeeeaace > Cr-Commit-Position: refs/heads/master@{#295714} TBR=asvitkine@chromium.org,shilpa.shri@samsung.com NOTREECHECKS=true NOTRY=true BUG=415554 Review URL: https://codereview.chromium.org/592833002 Cr-Commit-Position: refs/heads/master@{#295976} --- AUTHORS | 1 - chrome/app/nibs/BookmarkAllTabs.xib | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/AUTHORS b/AUTHORS index 33b356eb6fff6c..5ebe252d81c0ae 100644 --- a/AUTHORS +++ b/AUTHORS @@ -402,7 +402,6 @@ ShankarGanesh K Shez Baig Shiliu Wang Shiliu Wang -Shilpa Shri Shouqun Liu Shreeram Kushwaha Shreyas Gopal diff --git a/chrome/app/nibs/BookmarkAllTabs.xib b/chrome/app/nibs/BookmarkAllTabs.xib index f07e5dbe44b1af..8a8ac10be86e6b 100644 --- a/chrome/app/nibs/BookmarkAllTabs.xib +++ b/chrome/app/nibs/BookmarkAllTabs.xib @@ -832,6 +832,7 @@ YES +