Skip to content

Commit

Permalink
Valgrind cond error fix. Initialize uninitialized member variable.
Browse files Browse the repository at this point in the history
BUG=44147
TEST=valgrind bot should stay gree.
TBR=tyoshino@chromium.org,rvargas@chromium.org

Review URL: http://codereview.chromium.org/2071006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47251 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
oshima@chromium.org committed May 14, 2010
1 parent 8dc64b4 commit d4db59c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 24 deletions.
1 change: 1 addition & 0 deletions chrome/browser/chromeos/cros/cros_library.cc
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ CrosLibrary::CrosLibrary() : library_loader_(NULL),
own_mount_loader_(true),
own_network_loader_(true),
own_power_loader_(true),
own_screen_lock_lib_(true),
own_speech_synthesis_library_(true),
own_synaptics_library_(true),
loaded_(false),
Expand Down
24 changes: 0 additions & 24 deletions tools/valgrind/memcheck/suppressions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2908,27 +2908,3 @@
fun:_ZN14RunnableMethodIN10URLFetcher4CoreEMS1_FvvE6Tuple0E3RunEv
fun:_ZN11MessageLoop7RunTaskEP4Task
}
{
bug_44147
Memcheck:Cond
fun:_ZN8chromeos11CrosLibraryD0Ev
fun:_ZN22DefaultSingletonTraitsIN8chromeos11CrosLibraryEE6DeleteEPS1_
fun:_ZN9SingletonIN8chromeos11CrosLibraryE22DefaultSingletonTraitsIS1_ES1_E6OnExitEPv
fun:_ZN4base13AtExitManager19ProcessCallbacksNowEv
fun:_ZN4base13AtExitManagerD1Ev
...
fun:main
}
{
bug_44130
Memcheck:Leak
...
fun:_ZN7history32TopSitesTest_*
fun:_ZN7testing4Test3RunEv
fun:_ZN7testing8internal12TestInfoImpl3RunEv
fun:_ZN7testing8TestCase3RunEv
fun:_ZN7testing8internal12UnitTestImpl11RunAllTestsEv
fun:_ZN7testing8UnitTest3RunEv
fun:_ZN9TestSuite3RunEv
fun:main
}

0 comments on commit d4db59c

Please sign in to comment.