From 8a4e530f4fe04c07b6dc6efa52cf273d735abe6f Mon Sep 17 00:00:00 2001 From: Alan Cutter Date: Tue, 25 Sep 2018 00:16:56 +0000 Subject: [PATCH] Fix grey border around Chrome OS system tray bubble The BubbleBorder shadow setting NO_SHADOW was identical to BIG_SHADOW until https://chromium-review.googlesource.com/c/chromium/src/+/1195342. That CL attempted to update all existing uses of NO_SHADOW to BIG_SHADOW to avoid changing existing behaviour but it missed the usage in TrayBubbleView. This CL updates NO_SHADOW to BIG_SHADOW to revert an unintended change in behaviour. Current: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359605&signed_aid=gEEyLLd-AdZImC9nKec-5A==&inline=1 After reverting https://chromium-review.googlesource.com/c/chromium/src/+/1195342: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359606&signed_aid=iw3ONXWvygIGZHFz4GBIoQ==&inline=1 After this CL: https://bugs.chromium.org/p/chromium/issues/attachment?aid=359607&signed_aid=_oDSWBycRhw3Vs3_Tgp0Qg==&inline=1 Bug: 884653 Change-Id: Idd33394fbf92b7711705fd081889d0d964c5ba37 Reviewed-on: https://chromium-review.googlesource.com/1240216 Reviewed-by: Steven Bennetts Commit-Queue: Alan Cutter Cr-Commit-Position: refs/heads/master@{#593765} --- ash/system/tray/tray_bubble_view.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ash/system/tray/tray_bubble_view.cc b/ash/system/tray/tray_bubble_view.cc index 8613c9fb99a86d..162dfc02dad457 100644 --- a/ash/system/tray/tray_bubble_view.cc +++ b/ash/system/tray/tray_bubble_view.cc @@ -206,7 +206,7 @@ TrayBubbleView::TrayBubbleView(const InitParams& init_params) bubble_border_(new BubbleBorder( arrow(), init_params.has_shadow ? BubbleBorder::NO_ASSETS - : BubbleBorder::NO_SHADOW, + : BubbleBorder::BIG_SHADOW, init_params.bg_color.value_or(gfx::kPlaceholderColor))), owned_bubble_border_(bubble_border_), is_gesture_dragging_(false),