Skip to content

Commit

Permalink
Remove BUG= and TEST= checks from upload commit presubmit check.
Browse files Browse the repository at this point in the history
Fix PRESUBMIT.py to exclude Makefile.

BUG=none
TEST=presubmit check is less noisy

Review URL: http://codereview.chromium.org/5976009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71622 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
maruel@chromium.org committed Jan 18, 2011
1 parent d6ba5a0 commit 3e4eb11
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@
"""

_EXCLUDED_PATHS = (
r"breakpad[\\\/].*",
r"net/tools/spdyshark/[\\\/].*",
r"skia[\\\/].*",
r"v8[\\\/].*",
r"^breakpad[\\\/].*",
r"^net/tools/spdyshark/[\\\/].*",
r"^skia[\\\/].*",
r"^v8[\\\/].*",
r".*MakeFile$",
)

_TEXT_FILES = (
Expand Down Expand Up @@ -106,10 +107,6 @@ def _CommonChecks(input_api, output_api):
input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
input_api, output_api, source_file_filter=sources))
results.extend(input_api.canned_checks.CheckChangeHasBugField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasTestField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
input_api, output_api, source_file_filter=text_files))
results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
Expand Down Expand Up @@ -171,6 +168,10 @@ def CheckChangeOnCommit(input_api, output_api):
'http://build.chromium.org/p/chromium/json/builders?filter=1',
6,
IGNORED_BUILDERS))
results.extend(input_api.canned_checks.CheckChangeHasBugField(
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasTestField(
input_api, output_api))
return results


Expand Down

0 comments on commit 3e4eb11

Please sign in to comment.