Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GNU source location presentation #1515

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tothambrus11
Copy link
Contributor

The common syntax for referring to lines and columns is to write line:column instead of line.column. When I make this change, the link will become clickable in VSCode.

The common syntax for referring to lines and columns is to write line:column instead of line.column. When I make this change, the link will become clickable in VSCode.
@dabrahams
Copy link
Collaborator

dabrahams commented Jun 29, 2024

I'd have used that syntax but it's not one of the ones documented as being usable for anything having a range of locations. Is that merely an oversight in the docs?

sourcefile:line1.column1-line2.column2: message
sourcefile:line1.column1-column2: message
sourcefile:line1-line2: message

Regardless, if VSCode doesn't support the format we are currently using, a change should be submitted to fix that.

@tothambrus11
Copy link
Contributor Author

Sorry for the oversight, gcc indeed outputs the ranges like that. Now, I cannot seem to reproduce the problem neither with relative nor absolute paths, it's a bit weird...
So we can stick with the original format, but then the second part should be made consistent with the first: line.column-line.column instead of line.column-line:column

@dabrahams
Copy link
Collaborator

@tothambrus11 Languishing PRs are bad for the project. I think this could still be merged, but I can't make changes to your branch. Can you please merge main into this so testing will be re-triggered?

Also, it would be great if you could review the open PRs to see if you have any others like this.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.28%. Comparing base (f1b2d58) to head (91f6642).

Files with missing lines Patch % Lines
Sources/FrontEnd/SourceRange.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1515   +/-   ##
=======================================
  Coverage   88.28%   88.28%           
=======================================
  Files         381      381           
  Lines       22910    22910           
=======================================
+ Hits        20225    20227    +2     
+ Misses       2685     2683    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tothambrus11
Copy link
Contributor Author

@dabrahams good point, thanks for reminding! I closed the other PR because it has already become somewhat obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants