-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GNU source location presentation #1515
base: main
Are you sure you want to change the base?
Conversation
The common syntax for referring to lines and columns is to write line:column instead of line.column. When I make this change, the link will become clickable in VSCode.
I'd have used that syntax but it's not one of the ones documented as being usable for anything having a range of locations. Is that merely an oversight in the docs?
Regardless, if VSCode doesn't support the format we are currently using, a change should be submitted to fix that. |
Sorry for the oversight, gcc indeed outputs the ranges like that. Now, I cannot seem to reproduce the problem neither with relative nor absolute paths, it's a bit weird... |
@tothambrus11 Languishing PRs are bad for the project. I think this could still be merged, but I can't make changes to your branch. Can you please merge Also, it would be great if you could review the open PRs to see if you have any others like this. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1515 +/- ##
=======================================
Coverage 88.28% 88.28%
=======================================
Files 381 381
Lines 22910 22910
=======================================
+ Hits 20225 20227 +2
+ Misses 2685 2683 -2 ☔ View full report in Codecov by Sentry. |
@dabrahams good point, thanks for reminding! I closed the other PR because it has already become somewhat obsolete. |
The common syntax for referring to lines and columns is to write line:column instead of line.column. When I make this change, the link will become clickable in VSCode.