Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go over features that create more complexity than they're worth #442

Closed
caendesilva opened this issue May 22, 2022 · 7 comments
Closed

Go over features that create more complexity than they're worth #442

caendesilva opened this issue May 22, 2022 · 7 comments

Comments

@caendesilva
Copy link
Member

Before releasing v1 I want to make sure the code is stable, and part of this is to ensure the code is easy to maintain. To do this I want to reduce undue complexity. I think Hyde as it is now should focus on the 80% use case. Features can always be brought back if there is demand but for now I want to keep things very light.

Currently considering removing the authors.yml file. I don't think that many Hyde projects as of now will use that many authors, so I think those defaults can defined in the main config file and having it for a single author as having a single-purpose yml file adds more complexity than it's IMO worth at this point in time.

@caendesilva
Copy link
Member Author

I think I will remove the "Asset Locations and Versions" section in the config.

Disabling the styles is easy to do in the Blade views, and if you're needing to change styles, you probably need to update Blade views which means that you obviously know how to do that and you can just update the blade view.

@caendesilva
Copy link
Member Author

I might move the "Footer Text" setting to a Markdown/Blade include in an _includes directory

@caendesilva
Copy link
Member Author

A nice way to define authors would be with a helper facade in the config. Here's an example idea:

'authors' => [
    new Author([
        'username' => 'mr_hyde',
        'name' => 'Mr Hyde',
        'website' => 'hydephp.com',
    ]),
    
    new Author([
        'username' => 'ms_hyde',
        'name' => 'Miss Hyde',
    ]),
];

This has the added benefit of ensuring all Authors have a username as the schema will be right in the config which I really like.

@caendesilva
Copy link
Member Author

I really like the validators, but they add an extra dependency. And since they are so simple it should be fast and easy to write a custom implementation.

@caendesilva
Copy link
Member Author

I also don't think we need the AppServiceProvider.

@caendesilva
Copy link
Member Author

caendesilva commented Jun 7, 2022

Am also considering handling the creation of required directories in the app bootstrapping file

Edit: Or we just skip this all together and handle it with .gitkeeps

@caendesilva
Copy link
Member Author

Closing to handle further discussion in hydephp/develop#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant