[2.x] Rename docs.sidebar_group_labels to docs.sidebar.labels #2315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored configuration option 'docs.sidebar_group_labels' to 'docs.sidebar.labels' throughout the codebase, documentation, and tests. Updated relevant documentation and release notes to reflect this breaking change and provided upgrade instructions.
There was a problem hiding this comment.
Pull Request Overview
This PR renames the configuration option docs.sidebar_group_labels to docs.sidebar.labels to improve consistency and organization in the configuration structure. The change moves the labels configuration into a nested sidebar object.
- Refactored configuration key from
docs.sidebar_group_labelstodocs.sidebar.labels - Updated code references, tests, and documentation to use the new configuration structure
- Added comprehensive upgrade instructions and release notes for this breaking change
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/framework/tests/Feature/AutomaticNavigationConfigurationsTest.php | Updated test cases to use new nested configuration structure |
| packages/framework/src/Framework/Features/Navigation/NavigationMenuGenerator.php | Updated code to reference new configuration key and removed TODO comment |
| docs/creating-content/documentation-pages.md | Updated documentation example to show new nested configuration format |
| RELEASE_NOTES.md | Added breaking change entry with detailed upgrade instructions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2315 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2000 2000
===========================================
Files 197 197
Lines 5178 5178
===========================================
Hits 5178 5178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emmadesilva
changed the title
emmadesilva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored configuration option 'docs.sidebar_group_labels' to 'docs.sidebar.labels' throughout the codebase, documentation, and tests. Updated relevant documentation and release notes to reflect this breaking change and provided upgrade instructions.