[2.x] Improve the media file instance API #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmadesilva
force-pushed
the
improve-the-media-file-instance-api
branch
from
9b66987 to
96b1856
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1932 +/- ##
=============================================================
- Coverage 100.00% 99.97% -0.03%
- Complexity 1886 1887 +1
=============================================================
Files 193 193
Lines 4978 4983 +5
=============================================================
+ Hits 4978 4982 +4
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
improve-the-media-file-instance-api
branch
from
f4b2810 to
5c77557
Compare
Member
Author
|
I started adding back support for media files not backed by a file on disk c48a731, but realized that won't make sense, because how would they be used? If they have no contents we have nothing to copy to the output directory. |
emmadesilva
force-pushed
the
improve-the-media-file-instance-api
branch
from
06fd82d to
ad58ca7
Compare
emmadesilva
force-pushed
the
improve-the-media-file-instance-api
branch
2 times, most recently
from
24571bf to
5275c9e
Compare
This is quite important so I want it properly tested
emmadesilva
force-pushed
the
improve-the-media-file-instance-api
branch
from
5275c9e to
a329652
Compare
emmadesilva
force-pushed
the
improve-the-media-file-instance-api
branch
from
d4c3a5e to
ff18348
Compare
emmadesilva
added a commit
that referenced
this pull request
Sep 8, 2024
…-api [2.x] Improve the media file instance API
emmadesilva
added a commit
that referenced
this pull request
Sep 8, 2024
…-api [2.x] Improve the media file instance API
emmadesilva
added a commit
that referenced
this pull request
Sep 8, 2024
…-api [2.x] Improve the media file instance API
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Makes large improvements to the Asset API #1904 by creating a more fluent interface for interacting with media assets. It also removes the media link helper (replacing #1914), now using the Asset API for all media link retrievals. This has the side effect of media files now being required to exist in the project, and that cache busting keys are now consistently added to all media links, and media links will now be qualified using the base URL if set.
Auxiliary Changes
The filesystem facade has been updated to contain the mime type finder.