[2.x] Improve Markdown service container bindings #1922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #1922 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1876 1876
===========================================
Files 192 192
Lines 4954 4958 +4
===========================================
+ Hits 4954 4958 +4 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
improved-markdown-service-container-binding
branch
from
a3c7140 to
aa76b40
Compare
Doesn't feel worth it to split out this test into two, so rename is better
This reverts commit 45050ba.
This allows it to be mocked in unit tests
emmadesilva
force-pushed
the
improved-markdown-service-container-binding
branch
from
7e35b3b to
19b8b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.