-
-
Notifications
You must be signed in to change notification settings - Fork 12
[2.x] Experiment with removing the mediaLink method
#1914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
948aabd to
5bd7def
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1914 +/- ##
===========================================================
Coverage ? 100.00%
Complexity ? 1871
===========================================================
Files ? 192
Lines ? 4942
Branches ? 0
===========================================================
Hits ? 4942
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
93e0d25 to
8ae2156
Compare
fc66746 to
60ad468
Compare
This reverts commit 03961ae.
2cbca27 to
5b4474e
Compare
5b4474e to
0e3b96d
Compare
|
I'm starting to remember why we have two methods. Media link was intended to be the main way to use get assets, as it uses the more compatible relative links. The second parameter was for things where specs required absolute urls like metadata. But I did not document this so I forgot it. |
|
Drafting until I consider what solves the right problems the best way. |
f72298f to
67d663f
Compare
Maybe we should improve the object API by adding |
|
Superseded by #1932 |
mediaLink methodmediaLink method
Part of #1904 and removes the
mediaLinkhelper as it can be merged into the main asset() helper.