Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Jul 26, 2024

Part of #1904 and removes the mediaLink helper as it can be merged into the main asset() helper.

@emmadesilva emmadesilva mentioned this pull request Jul 26, 2024
21 tasks
@emmadesilva emmadesilva force-pushed the normalize-asset-helpers branch from 948aabd to 5bd7def Compare July 26, 2024 18:58
@codecov
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (normalize-the-asset-api@314c57a). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             normalize-the-asset-api     #1914   +/-   ##
===========================================================
  Coverage                           ?   100.00%           
  Complexity                         ?      1871           
===========================================================
  Files                              ?       192           
  Lines                              ?      4942           
  Branches                           ?         0           
===========================================================
  Hits                               ?      4942           
  Misses                             ?         0           
  Partials                           ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva force-pushed the normalize-asset-helpers branch from 93e0d25 to 8ae2156 Compare July 26, 2024 19:07
@emmadesilva emmadesilva force-pushed the normalize-asset-helpers branch from fc66746 to 60ad468 Compare July 26, 2024 19:08
@emmadesilva emmadesilva force-pushed the normalize-asset-helpers branch from 2cbca27 to 5b4474e Compare July 27, 2024 13:32
@emmadesilva emmadesilva force-pushed the normalize-asset-helpers branch from 5b4474e to 0e3b96d Compare July 27, 2024 13:35
@emmadesilva
Copy link
Member Author

I'm starting to remember why we have two methods. Media link was intended to be the main way to use get assets, as it uses the more compatible relative links. The second parameter was for things where specs required absolute urls like metadata. But I did not document this so I forgot it.

@emmadesilva
Copy link
Member Author

Drafting until I consider what solves the right problems the best way.

@emmadesilva emmadesilva marked this pull request as draft July 27, 2024 15:45
@emmadesilva emmadesilva force-pushed the normalize-asset-helpers branch from f72298f to 67d663f Compare July 27, 2024 15:45
@emmadesilva
Copy link
Member Author

Drafting until I consider what solves the right problems the best way.

Maybe we should improve the object API by adding path() and link() instance helpers.

@emmadesilva
Copy link
Member Author

Superseded by #1932

@emmadesilva emmadesilva closed this Sep 4, 2024
@emmadesilva emmadesilva changed the title [2.x] Remove the mediaLink method [2.x] Experiment with removing the mediaLink method Sep 4, 2024
@emmadesilva emmadesilva deleted the normalize-asset-helpers branch November 17, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants