[2.x] Normalize media path helpers to unify naming with HydePages #1911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1911 +/- ##
===========================================================
Coverage 100.00% 100.00%
+ Complexity 1873 1871 -2
===========================================================
Files 192 192
Lines 4944 4940 -4
===========================================================
- Hits 4944 4940 -4 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
normalize-media-path-helpers
branch
from
c00e864 to
a60e91b
Compare
Member
Author
|
Thinking if we should move the directory helpers as well, but not sure if it is worth it at this time. |
This reverts commit 4091051.
emmadesilva
force-pushed
the
normalize-media-path-helpers
branch
3 times, most recently
from
28d8496 to
9fedf1a
Compare
This is so we can get an overview of the outdated methods that are inconsistently named This means they are lost from the HydeKernel which could be a problem to review before merge.
This reverts commit 2004a4e.
emmadesilva
force-pushed
the
normalize-media-path-helpers
branch
from
956dac2 to
678b6f7
Compare
emmadesilva
commented
Jul 26, 2024
emmadesilva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #1904
// Renames to match MediaFile with HydePage base Hyde::mediaPath => MediaFile::sourcePath Hyde::siteMediaPath => MediaFile::outputPath