[2.x] Update the Markdown::render method to always use the smart Markdown service
#1900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmadesilva
force-pushed
the
simplify-markdown-rendering-helper
branch
from
a53c5d0 to
1860756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplification means that the method is more predictable, and better follows the principle of least astonishment. I've been so confused so many times about this that using our Markdown helper does not always mean that we get our Markdown features. This change means that any time you call this method, custom Markdown features like our shortcodes and processors will be applied.
A side effect of this is in unit tests, as the method now requires the kernel and config to be set up.