[2.x] Update the build service to group together dynamic pages #1897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #1897 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1865 1867 +2
===========================================
Files 191 191
Lines 4923 4927 +4
===========================================
+ Hits 4923 4927 +4 ☔ View full report in Codecov by Sentry. |
emmadesilva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
BuildServiceto group all dynamic pages (InMemoryPageinstances) together under a "Dynamic Pages" category during the build process. This is because this otherwise can very quickly grow to have a bunch of single item progress bars when using a lot of extended pages of this type.