[1.x] Update the post author class to prepare for the v2 overhaul #1794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
emmadesilva
force-pushed
the
prepare-post-author-changes
branch
from
e43c6be to
6c887e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1794 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1764 1764
===========================================
Files 182 182
Lines 4711 4711
===========================================
Hits 4711 4711 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
prepare-post-author-changes
branch
from
f16f38f to
b3c4cbb
Compare
emmadesilva
force-pushed
the
prepare-post-author-changes
branch
from
b3c4cbb to
d74d84a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Tie in with #1782 to smooth over the upgrade to v2
Changes
Update post author name to fall back to username at construct time
Cherry picks commit 0dfb841 from #1782
Deprecate the
PostAuthor::getName()methodCherry picks commit 2f54b9f from #1782
Remove nullable modifier from author name as it is now never null
Since the author name is now always set at construct time, we can remove the nullable modifier from the property.