[2.x] Even smarter sitemap generation #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #1744 +/- ##
=============================================
+ Coverage 99.95% 99.97% +0.02%
+ Complexity 1810 1808 -2
=============================================
Files 185 185
Lines 4793 4788 -5
=============================================
- Hits 4791 4787 -4
+ Misses 2 1 -1 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
even-smarter-sitemap-generation
branch
from
9f30e49 to
2d29ed8
Compare
This is more fault tolerant
emmadesilva
force-pushed
the
even-smarter-sitemap-generation
branch
from
163fb4e to
5801af2
Compare
Also gives documentation indexes top priority
Member
Author
|
We could actually check post publish dates for priorities, but don't think the complexity is worth it since Google mostly ignores these |
Either we add something like this for the changefreq logic, or we remove it, and I think it can be removed since it's not documented, and it's such an uncommon use case. And if one is unhappy with the generation, a better way is to customize the class to add custom logic.
emmadesilva
force-pushed
the
even-smarter-sitemap-generation
branch
from
5e0f46d to
6c61928
Compare
emmadesilva
force-pushed
the
even-smarter-sitemap-generation
branch
from
f11abd9 to
29661ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
processing_time_msattribute in thesitemap.xmlfile as it adds no value in f2ee36fsitemap.dynamic_priorityconfig option in 6c61928