[2.x] Refactor features class to simplify it and extract an enum #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmadesilva
changed the title
emmadesilva
force-pushed
the
refactor-features-class-to-extract-an-enum
branch
from
5dc824f to
e6277b4
Compare
This method might not actually provide value, as it's not interesting information to have. It has also not been released, so this change is not breaking.
No idea why this was the way it was
emmadesilva
force-pushed
the
refactor-features-class-to-extract-an-enum
branch
from
23f4ebf to
006bce8
Compare
emmadesilva
force-pushed
the
refactor-features-class-to-extract-an-enum
branch
from
ed1e162 to
ed86b9a
Compare
emmadesilva
force-pushed
the
refactor-features-class-to-extract-an-enum
branch
from
e491fca to
c548480
Compare
emmadesilva
force-pushed
the
refactor-features-class-to-extract-an-enum
branch
from
c548480 to
db3d5f8
Compare
emmadesilva
force-pushed
the
refactor-features-class-to-extract-an-enum
branch
from
a3d16bd to
f7f9c37
Compare
This reverts commit d27a416.
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1647. Contains a highly breaking config change in c548480