[2.x] Merge trait back into menu class and make navigation groups extend the menu class #1645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially reverts #1630
Extending the NavigationMenu class with the NavigationGroup class implies an "is-a" relationship between them. If a NavigationGroup is fundamentally a type of NavigationMenu with additional features or behavior, inheritance could be appropriate.
If you consider a group as a specialized type of menu, where a menu can contain both individual items and groups, then extending the menu class can make semantic sense. In object-oriented programming, inheritance signifies an "is-a" relationship. If a group "is-a" type of menu with additional features or behavior, extending the menu class can reflect this relationship.
Targets #1642