Skip to content

Conversation

@emmadesilva
Copy link
Member

Essentially reverts #1630

Extending the NavigationMenu class with the NavigationGroup class implies an "is-a" relationship between them. If a NavigationGroup is fundamentally a type of NavigationMenu with additional features or behavior, inheritance could be appropriate.

If you consider a group as a specialized type of menu, where a menu can contain both individual items and groups, then extending the menu class can make semantic sense. In object-oriented programming, inheritance signifies an "is-a" relationship. If a group "is-a" type of menu with additional features or behavior, extending the menu class can reflect this relationship.

Targets #1642

@emmadesilva emmadesilva marked this pull request as ready for review March 28, 2024 18:58
@emmadesilva emmadesilva force-pushed the restructure-navigation-item-oop-design branch from 24d516f to cc803ba Compare March 28, 2024 18:58
@codecov
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (f80795f) to head (24d516f).

❗ Current head 24d516f differs from pull request most recent head cc803ba. Consider uploading reports for the commit cc803ba to get more accurate results

Additional details and impacted files
@@                        Coverage Diff                         @@
##             simplify-public-navigation-apis    #1645   +/-   ##
==================================================================
  Coverage                              99.97%   99.97%           
  Complexity                              1775     1775           
==================================================================
  Files                                    185      184    -1     
  Lines                                   4792     4791    -1     
==================================================================
- Hits                                    4791     4790    -1     
  Misses                                     1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva merged commit 544769a into simplify-public-navigation-apis Mar 28, 2024
@emmadesilva emmadesilva deleted the restructure-navigation-item-oop-design branch March 28, 2024 18:59
@emmadesilva emmadesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants