Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Mar 18, 2024

This breaking PR renames some HTML identifiers that are using camelCase instead of kebab-case.

Upgrade path:

If you have used any of the following selectors in custom code you wrote yourself, you will need to update to use the new changed IDs.

  • Rename HTML ID #searchMenu to #search-menu
  • Rename HTML ID #searchMenuButton to #search-menu-button
  • Rename HTML ID #searchMenuButtonMobile to #search-menu-button-mobile

@emmadesilva emmadesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Mar 18, 2024
@codecov
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.87%. Comparing base (81d73b3) to head (5a71241).

❗ Current head 5a71241 differs from pull request most recent head be0f780. Consider uploading reports for the commit be0f780 to get more accurate results

Additional details and impacted files
@@                       Coverage Diff                        @@
##             improved-navigation-internals    #1622   +/-   ##
================================================================
  Coverage                            99.87%   99.87%           
  Complexity                            1778     1778           
================================================================
  Files                                  184      184           
  Lines                                 4809     4809           
================================================================
  Hits                                  4803     4803           
  Misses                                   6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva marked this pull request as ready for review March 18, 2024 18:59
@emmadesilva emmadesilva merged commit 54c4470 into improved-navigation-internals Mar 18, 2024
@emmadesilva emmadesilva deleted the normalize-navigation-id-names branch March 18, 2024 18:59
@emmadesilva emmadesilva removed the run-visual-tests Internal label to trigger Browserstack visual testing label Mar 18, 2024
@emmadesilva emmadesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants