Skip to content

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Feb 28, 2024

Makes so that the generator always place navigation menu items in dropdowns when set in front matter, regardless of subdirectory group config.

@emmadesilva emmadesilva force-pushed the refactor-main-menu-generation-to-be-deterministic branch from e355274 to 080d204 Compare February 28, 2024 10:15
@codecov
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (e2b14c9) to head (353603b).

Additional details and impacted files
@@                       Coverage Diff                        @@
##             improved-navigation-internals    #1597   +/-   ##
================================================================
  Coverage                            99.95%   99.95%           
  Complexity                            1774     1774           
================================================================
  Files                                  183      183           
  Lines                                 4796     4796           
================================================================
  Hits                                  4794     4794           
  Misses                                   2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva marked this pull request as ready for review February 28, 2024 12:00
@emmadesilva emmadesilva changed the title [2.x] Refactor main menu generation to be deterministic [2.x] Always place navigation menu items in dropdowns when set in front matter Feb 28, 2024
@emmadesilva emmadesilva merged commit 5eb64a1 into improved-navigation-internals Feb 28, 2024
@emmadesilva emmadesilva deleted the refactor-main-menu-generation-to-be-deterministic branch February 28, 2024 12:02
emmadesilva added a commit that referenced this pull request Feb 28, 2024
@emmadesilva emmadesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants