[2.x] Merge menu generator actions into single class #1579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1579 +/- ##
===================================================================
- Coverage 100.00% 99.97% -0.03%
+ Complexity 1764 1758 -6
===================================================================
Files 185 183 -2
Lines 4775 4758 -17
===================================================================
- Hits 4775 4757 -18
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
merge-menu-generator-actions-into-single-class
branch
from
6e4303f to
ed5d073
Compare
emmadesilva
force-pushed
the
merge-menu-generator-actions-into-single-class
branch
from
f1562e4 to
8567451
Compare
emmadesilva
force-pushed
the
merge-menu-generator-actions-into-single-class
branch
from
1df091f to
59a3cc4
Compare
This reverts commit c7459fb.
emmadesilva
force-pushed
the
merge-menu-generator-actions-into-single-class
branch
from
6388dc3 to
5aa4b4e
Compare
This reverts commit d6649f0.
All logic has been moved to the base class
Was only needed for parent compatibility
emmadesilva
force-pushed
the
merge-menu-generator-actions-into-single-class
branch
from
ea6e25a to
e06f1c0
Compare
emmadesilva
force-pushed
the
merge-menu-generator-actions-into-single-class
branch
from
0e35943 to
eb5d79e
Compare
The ternary logic used in the class requires that only one of these two classes are used
emmadesilva
deleted the
merge-menu-generator-actions-into-single-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.