[2.x] Refactor navigation menu generators #1578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1578 +/- ##
====================================================================
+ Coverage 99.97% 100.00% +0.02%
+ Complexity 1766 1764 -2
====================================================================
Files 184 185 +1
Lines 4780 4775 -5
====================================================================
- Hits 4779 4775 -4
+ Misses 1 0 -1 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
refactor-main-navigation-menu
branch
from
5e280f5 to
e7a9f6f
Compare
emmadesilva
changed the title
emmadesilva
force-pushed
the
refactor-main-navigation-menu
branch
from
3383e31 to
5609efa
Compare
Normalizes the implementations
emmadesilva
force-pushed
the
refactor-main-navigation-menu
branch
from
0ce1110 to
9af0fbc
Compare
emmadesilva
force-pushed
the
refactor-main-navigation-menu
branch
from
9ed2798 to
351ff64
Compare
Using groupKey instead of identifier as the latter can also apply to the pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets v2.x via #1568 and refactors the new generator to be deterministic and reduces overlapping code with the sidebar generator.