[2.x] Simplify dropdown data handling #1577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmadesilva
force-pushed
the
simplify-dropdown-data-handling
branch
from
34f81bb to
e8c0eb7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1577 +/- ##
===================================================================
- Coverage 100.00% 99.97% -0.03%
- Complexity 1763 1766 +3
===================================================================
Files 184 184
Lines 4773 4780 +7
===================================================================
+ Hits 4773 4779 +6
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
emmadesilva
force-pushed
the
simplify-dropdown-data-handling
branch
from
fbfc152 to
36ba2a0
Compare
This means that when creating navigation dropdown items directly, you no longer get the normalization
emmadesilva
force-pushed
the
simplify-dropdown-data-handling
branch
from
36ba2a0 to
2c389e4
Compare
emmadesilva
force-pushed
the
simplify-dropdown-data-handling
branch
from
61d9918 to
e2e0f2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets v2.x via #1568
I've complicated things. This attempts to simplify the dropdown data generation by moving the responsibilities. If we call NavItem::dropdown we should have already found the data to use. If the user calls it themselves they have the responsibility (and expectation) that the data they manually enter is used. It's not the responsibility of the data model to perform such extensive dynamic data generation.