Improve internal page model structure #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the returned files are already the just base names, this does nothing
Since this class both acts like the model and the parser (since it does not need parsing) it should implement the contract, so it can be properly recognized by Hyde internals.
Besides that I think it looks nicer, it ensures we use the canonical paths and extensions.
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=========================================
Coverage 99.02% 99.03%
- Complexity 750 757 +7
=========================================
Files 97 97
Lines 1956 1971 +15
=========================================
+ Hits 1937 1952 +15
Misses 19 19
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update refactors the internal page models to ensure a more predictable and consistent state. This is in large part done by further defining the page model contract, and abstracting the implementations to the base class, leading to less boilerplate for the actual implementations, while gaining a more defined source of truth. It also adds the scaffolding to customize more output directories, and unifies this with the legacy documentation output paths. Besides that, this PR does not add much in the terms of features, it does make several changes that may be considered breaking to the package developers.