Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline styling to front matter for post images #20

Closed
caendesilva opened this issue Jun 9, 2022 · 2 comments
Closed

Add inline styling to front matter for post images #20

caendesilva opened this issue Jun 9, 2022 · 2 comments
Assignees
Labels
feature Suggests a new feature

Comments

@caendesilva
Copy link
Member

caendesilva commented Jun 9, 2022

---
image: 
  path: cover.png
  style: 'max-height: 100px'
---
@caendesilva caendesilva added enhancement Improves an existing feature feature Suggests a new feature and removed enhancement Improves an existing feature labels Aug 27, 2022
@caendesilva
Copy link
Member Author

caendesilva commented Sep 14, 2022

Should only be enabled in if 'allow_html' => true in config/markdown.php

@caendesilva caendesilva self-assigned this Sep 14, 2022
@caendesilva caendesilva linked a pull request Sep 14, 2022 that will close this issue
@caendesilva
Copy link
Member Author

I originally added this as a feature request because I wanted to set a max height to crop an image. I should just have cropped the image. There are very few reasons to use one-off inline styles. Modify your images beforehand, or publish the image.blade.php component to add custom classes. I considered adding a class property, but again, the point of the component is to have a consistent presentation, so why use a one-off style?

@caendesilva caendesilva closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Suggests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant