Remove the sitemap processing_time_ms attribute as it adds no value

This is not a standard attribute, it's just a "cool thing" that adds no real value, as this file is not even intended for humans to read.

Author: emmadesilva

RELEASE_NOTES.md

@@ -27,6 +27,7 @@ This serves two purposes:
 - Minor: Data collection files are now validated for syntax errors during discovery in https://github.com/hydephp/develop/pull/1732
 - Minor: Methods in the `Includes` facade now return `HtmlString` objects instead of `string` in https://github.com/hydephp/develop/pull/1738. For more information, see below.
 - Minor: `Includes::path()` and  `Includes::get()` methods now normalizes paths to be basenames to match the behaviour of the other include methods in https://github.com/hydephp/develop/pull/1738. This means that nested directories are no longer supported, as you should use a data collection for that.
+- Minor: The `processing_time_ms` attribute in the `sitemap.xml` file has now been removed in https://github.com/hydephp/develop/pull/1744
 - Improved the sitemap data generation to be even smarter in https://github.com/hydephp/develop/pull/1744
 - The `hasFeature` method on the Hyde facade and HydeKernel now only accepts a Feature enum value instead of a string for its parameter.
 - Changed how the documentation search is generated, to be an `InMemoryPage` instead of a post-build task.

packages/framework/src/Framework/Features/XmlGenerators/SitemapGenerator.php

@@ -42,8 +42,6 @@ public function generate(): static
 
     public function getXml(): string
     {
-        $this->xmlElement->addAttribute('processing_time_ms', $this->getFormattedProcessingTime());
-
         return parent::getXml();
     }
 
@@ -121,10 +119,4 @@ protected function resolveRouteLink(Route $route): string
             return Hyde::url($route->getOutputPath());
         }
     }
-
-    /** @return numeric-string */
-    protected function getFormattedProcessingTime(): string
-    {
-        return (string) $this->getExecutionTimeInMs();
-    }
 }

packages/framework/tests/Feature/SitemapFeatureTest.php

@@ -45,7 +45,7 @@ public function testTheSitemapFeature()
     protected function expected(): string
     {
         return <<<'XML'
-        <urlset xmlns="https://www.sitemaps.org/schemas/sitemap/0.9" generator="HydePHP {{ dynamic }}" processing_time_ms="{{ dynamic }}">
+        <urlset xmlns="https://www.sitemaps.org/schemas/sitemap/0.9" generator="HydePHP {{ dynamic }}">
             <url>
                 <loc>https://example.com/contact.html</loc>
                 <lastmod>{{ dynamic }}</lastmod>