Move up conditional

emmadesilva · emmadesilva · commit e3552744fb05 · 2024-02-28T11:11:10.000+01:00
diff --git a/packages/framework/src/Framework/Features/Navigation/NavigationMenuGenerator.php b/packages/framework/src/Framework/Features/Navigation/NavigationMenuGenerator.php
@@ -120,14 +120,14 @@ protected function canAddRoute(Route $route): bool
 
     protected function canGroupRoute(Route $route): bool
     {
-        if (! $this->usesGroups) {
-            return false;
-        }
-
         if (! $this->generatesSidebar) {
             return $route->getPage()->navigationMenuGroup() !== null;
         }
 
+        if (! $this->usesGroups) {
+            return false;
+        }
+
         return true;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -120,14 +120,14 @@ protected function canAddRoute(Route $route): bool`
`120`	`120`
`121`	`121`	`protected function canGroupRoute(Route $route): bool`
`122`	`122`	`{`
`123`		`- if (! $this->usesGroups) {`
`124`		`- return false;`
`125`		`- }`
`126`		`-`
`127`	`123`	`if (! $this->generatesSidebar) {`
`128`	`124`	`return $route->getPage()->navigationMenuGroup() !== null;`
`129`	`125`	`}`
`130`	`126`
	`127`	`+ if (! $this->usesGroups) {`
	`128`	`+ return false;`
	`129`	`+ }`
	`130`	`+`
`131`	`131`	`return true;`
`132`	`132`	`}`
`133`	`133`