Remove internal validate existence flag

Author: emmadesilva

packages/framework/src/Support/Filesystem/MediaFile.php

@@ -25,9 +25,6 @@ class MediaFile extends ProjectFile
     /** @var array<string> The default extensions for media types */
     final public const EXTENSIONS = ['png', 'svg', 'jpg', 'jpeg', 'gif', 'ico', 'css', 'js'];
 
-    /** @internal Controls whether to validate the existence of the file, intended for unit testing. Turning this off may lead to unexpected behavior. */
-    public static bool $validateExistence = true;
-
     public readonly int $length;
     public readonly string $mimeType;
     public readonly string $hash;
@@ -36,7 +33,7 @@ public function __construct(string $path)
     {
         $path = $this->normalizePath($path);
 
-        if (static::$validateExistence && Filesystem::missing($path)) {
+        if (Filesystem::missing($path)) {
             throw new FileNotFoundException($path);
         }
 

packages/framework/tests/Unit/Foundation/FilesystemHasMediaFilesTest.php

@@ -28,17 +28,10 @@ protected function setUp(): void
         $this->filesystem = new TestableFilesystem(Hyde::getInstance());
 
         $mock = Mockery::mock(BaseFilesystem::class)->makePartial();
+        $mock->shouldReceive('missing')->andReturn(false)->byDefault();
         $mock->shouldReceive('size')->andReturn(100)->byDefault();
         $mock->shouldReceive('hash')->andReturn('hash')->byDefault();
         app()->instance(BaseFilesystem::class, $mock);
-
-        MediaFile::$validateExistence = false;
-    }
-
-    protected function tearDown(): void
-    {
-        parent::tearDown();
-        MediaFile::$validateExistence = true;
     }
 
     public function testAssetsMethodReturnsSameInstanceOnSubsequentCalls()

packages/framework/tests/Unit/Support/MediaFileUnitTest.php

@@ -45,8 +45,6 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        MediaFile::$validateExistence = false;
-
         $this->mockFilesystem = Mockery::mock(BaseFilesystem::class);
         app()->instance(BaseFilesystem::class, $this->mockFilesystem);
 
@@ -68,7 +66,6 @@ protected function tearDown(): void
     {
         parent::tearDown();
 
-        MediaFile::$validateExistence = true;
         Mockery::close();
     }
 
@@ -147,15 +144,6 @@ public function testConstructorWithVariousInputFormats()
         $this->assertSame('_media/foo.txt', MediaFile::make('media/foo.txt')->path);
     }
 
-    public function testConstructorWithValidationDisabled()
-    {
-        MediaFile::$validateExistence = false;
-        $this->mockFilesystem->shouldReceive('missing')->never();
-
-        $file = new MediaFile('non_existent_file.txt');
-        $this->assertInstanceOf(MediaFile::class, $file);
-    }
-
     public function testConstructorSetsProperties()
     {
         $file = new MediaFile('foo.txt');
@@ -285,8 +273,6 @@ public function testGetHashReturnsHash()
 
     public function testExceptionIsThrownWhenConstructingFileThatDoesNotExist()
     {
-        MediaFile::$validateExistence = true;
-
         $this->mockFilesystem->shouldReceive('missing')
             ->with(Hyde::path('_media/foo'))
             ->andReturn(true);
@@ -299,8 +285,6 @@ public function testExceptionIsThrownWhenConstructingFileThatDoesNotExist()
 
     public function testExceptionIsNotThrownWhenConstructingFileThatDoesExist()
     {
-        MediaFile::$validateExistence = true;
-
         $this->mockFilesystem->shouldReceive('missing')
             ->with(Hyde::path('_media/foo'))
             ->andReturn(false);