Split out each assertion group to its own test method

emmadesilva · emmadesilva · commit d7a3a28016c7 · 2024-09-07T13:54:00.000+02:00
diff --git a/packages/framework/tests/Feature/FilesystemFacadeTest.php b/packages/framework/tests/Feature/FilesystemFacadeTest.php
@@ -449,52 +449,91 @@ public function testMethodWithMixedSequentialAndNamedArgumentsSkippingMiddleOne(
         rmdir(Hyde::path('foo'));
     }
 
-    public function testFindMimeType()
+    public function testFindMimeTypeWithUnknownExtension()
     {
-        // Test fileinfo fallback for existing files where the extension is not in the lookup table
         $this->file('text.unknown', 'text');
         $this->assertSame('text/plain', Filesystem::findMimeType('text.unknown'));
+    }
 
+    public function testFindMimeTypeWithBlankFile()
+    {
         $this->file('blank.unknown', '');
         $this->assertSame('application/x-empty', Filesystem::findMimeType('blank.unknown'));
+    }
 
+    public function testFindMimeTypeWithEmptyFile()
+    {
         $this->file('empty.unknown');
         $this->assertSame('application/x-empty', Filesystem::findMimeType('empty.unknown'));
+    }
 
+    public function testFindMimeTypeWithJsonFile()
+    {
         $this->file('json.unknown', '{"key": "value"}');
         $this->assertSame('application/json', Filesystem::findMimeType('json.unknown'));
+    }
 
+    public function testFindMimeTypeWithXmlFile()
+    {
         $this->file('xml.unknown', '<?xml version="1.0" encoding="UTF-8"?><root></root>');
         $this->assertSame('text/xml', Filesystem::findMimeType('xml.unknown'));
+    }
 
+    public function testFindMimeTypeWithHtmlFile()
+    {
         $this->file('html.unknown', '<!DOCTYPE html><html><head><title>Test</title></head><body></body></html>');
         $this->assertSame('text/html', Filesystem::findMimeType('html.unknown'));
+    }
 
+    public function testFindMimeTypeWithYamlFile()
+    {
         $this->file('yaml.unknown', 'key: value');
         $this->assertSame('text/plain', Filesystem::findMimeType('yaml.unknown')); // YAML is not detected by fileinfo
+    }
 
+    public function testFindMimeTypeWithCssFile()
+    {
         $this->file('css.unknown', 'body { color: red; }');
         $this->assertSame('text/plain', Filesystem::findMimeType('css.unknown')); // CSS is not detected by fileinfo
+    }
 
+    public function testFindMimeTypeWithJsFile()
+    {
         $this->file('js.unknown', 'console.log("Hello, World!");');
         $this->assertSame('text/plain', Filesystem::findMimeType('js.unknown')); // JavaScript is not detected by fileinfo
+    }
 
+    public function testFindMimeTypeWithBinaryFile()
+    {
         $this->file('binary.unknown', "\x00\x01\x02\x03\x04\x05\x06\x07\x08\x09\x0A\x0B\x0C\x0D\x0E\x0F"); // 16 bytes of binary data
         $this->assertSame('application/octet-stream', Filesystem::findMimeType('binary.unknown'));
+    }
 
+    public function testFindMimeTypeWithPngFile()
+    {
         $this->file('png.unknown', base64_decode('iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkAAIAAAoAAvM1P4AAAAASUVORK5CYII=')); // 1x1 transparent PNG
         $this->assertSame('image/png', Filesystem::findMimeType('png.unknown'));
+    }
 
+    public function testFindMimeTypeWithJpegFile()
+    {
         $this->file('jpeg.unknown', base64_decode('/9j/4AAQSkZJRgABAQEAYABgAAD/4QA6RXhpZgAATU0AKgAAAAgAA1IBAAABAAAAngIBAAABAAAAnwICAAABAAAAnQ==')); // 1x1 JPEG
         $this->assertSame('image/jpeg', Filesystem::findMimeType('jpeg.unknown'));
+    }
 
+    public function testFindMimeTypeWithGifFile()
+    {
         $this->file('gif.unknown', base64_decode('R0lGODlhAQABAIAAAP///wAAACwAAAAAAQABAAACAkQBADs=')); // 1x1 GIF
         $this->assertSame('image/gif', Filesystem::findMimeType('gif.unknown'));
+    }
 
-        // Test non-existing file
+    public function testFindMimeTypeWithNonExistingFile()
+    {
         $this->assertSame('text/plain', Filesystem::findMimeType('non_existing_file.txt'));
+    }
 
-        // Test it uses lookup before fileinfo (so lookup overrides fileinfo)
+    public function testFindMimeTypeUsesLookupBeforeFileinfo()
+    {
         $this->file('file.png', 'Not PNG content');
         $this->assertSame('image/png', Filesystem::findMimeType('file.png'));
 
