Begin adding back support for fileless media file instances

Author: emmadesilva

packages/framework/src/Support/Filesystem/MediaFile.php

@@ -41,9 +41,13 @@ public function __construct(string $path)
     {
         parent::__construct($this->getNormalizedPath($path));
 
-        $this->length = $this->findContentLength();
-        $this->mimeType = $this->findMimeType();
-        $this->hash = $this->findHash();
+        if (Filesystem::exists($this->getAbsolutePath())) {
+            [$contentLength, $mimeType, $hash] = $this->getMetadata();
+
+            $this->length = $contentLength;
+            $this->mimeType = $mimeType;
+            $this->hash = $hash;
+        }
     }
 
     /**
@@ -172,10 +176,6 @@ protected function getNormalizedPath(string $path): string
         // Normalize the path to include the media directory
         $path = static::sourcePath(trim_slashes(Str::after($path, Hyde::getMediaDirectory())));
 
-        if (Filesystem::missing($path)) {
-            throw new FileNotFoundException($path);
-        }
-
         return $path;
     }
 
@@ -220,4 +220,17 @@ protected function findHash(): string
     {
         return Filesystem::hash($this->getPath(), 'crc32');
     }
+
+    protected function getMetadata(): array
+    {
+        if (Filesystem::missing($this->getAbsolutePath())) {
+            throw new FileNotFoundException($this->getPath(), "Cannot get metadata for a file that does not exist on disk. (File [{$this->getPath()}] not found)");
+        }
+
+        $contentLength = $this->findContentLength();
+        $mimeType = $this->findMimeType();
+        $hash = $this->findHash();
+
+        return [$contentLength, $mimeType, $hash];
+    }
 }

packages/framework/tests/Feature/Support/MediaFileTest.php

@@ -78,10 +78,13 @@ public function testMediaFilePathHandling()
         $this->assertSame('_media/subfolder/nested_file.txt', $mediaFile->getPath());
     }
 
-    public function testMediaFileExceptionHandling()
+    public function testCanCreateInMemoryMediaFileInstances()
     {
-        $this->expectException(FileNotFoundException::class);
-        MediaFile::make('non_existent_file.txt');
+        $mediaFile = MediaFile::make('non_existent_file.txt');
+
+        $this->assertInstanceOf(MediaFile::class, $mediaFile);
+
+        $this->assertSame('non_existent_file.txt', $mediaFile->getAbsolutePath());
     }
 
     public function testMediaDirectoryCustomization()

packages/framework/tests/Unit/Support/MediaFileUnitTest.php

@@ -288,7 +288,7 @@ public function testExceptionIsThrownWhenConstructingFileThatDoesNotExist()
             ->andReturn(true);
 
         $this->expectException(FileNotFoundException::class);
-        $this->expectExceptionMessage('File [_media/foo] not found.');
+        $this->expectExceptionMessage('Cannot get metadata for a file that does not exist on disk. (File [_media/foo] not found)');
 
         MediaFile::make('foo');
     }