Update navigation group to extend menu class

emmadesilva · emmadesilva · commit b412f3429857 · 2024-03-28T19:55:38.000+01:00
diff --git a/packages/framework/src/Framework/Features/Navigation/NavigationGroup.php b/packages/framework/src/Framework/Features/Navigation/NavigationGroup.php
@@ -14,18 +14,17 @@
 /**
  * Abstraction for a grouped navigation menu item, like a dropdown or a sidebar group.
  */
-class NavigationGroup
+class NavigationGroup extends NavigationMenu
 {
     protected string $label;
     protected int $priority;
 
     public function __construct(string $label, array $items = [], int $priority = NavigationMenu::LAST)
     {
-        $this->items = new Collection();
         $this->label = $label;
         $this->priority = $priority;
 
-        $this->add($items);
+        parent::__construct($items);
     }
 
     public static function create(string $label, array $items = [], int $priority = NavigationMenu::LAST): static

Original file line number	Diff line number	Diff line change
`@@ -14,18 +14,17 @@`
`14`	`14`	`/**`
`15`	`15`	`* Abstraction for a grouped navigation menu item, like a dropdown or a sidebar group.`
`16`	`16`	`*/`
`17`		`-class NavigationGroup`
	`17`	`+class NavigationGroup extends NavigationMenu`
`18`	`18`	`{`
`19`	`19`	`protected string $label;`
`20`	`20`	`protected int $priority;`
`21`	`21`
`22`	`22`	`public function __construct(string $label, array $items = [], int $priority = NavigationMenu::LAST)`
`23`	`23`	`{`
`24`		`- $this->items = new Collection();`
`25`	`24`	`$this->label = $label;`
`26`	`25`	`$this->priority = $priority;`
`27`	`26`
`28`		`- $this->add($items);`
	`27`	`+ parent::__construct($items);`
`29`	`28`	`}`
`30`	`29`
`31`	`30`	`public static function create(string $label, array $items = [], int $priority = NavigationMenu::LAST): static`