Use null check instead of instanceof on deprecated class

emmadesilva · emmadesilva · commit 9157cb4c6f21 · 2024-03-24T12:55:14.000+01:00
diff --git a/packages/framework/src/Framework/Features/Navigation/NavigationGroup.php b/packages/framework/src/Framework/Features/Navigation/NavigationGroup.php
@@ -79,7 +79,7 @@ protected function addItem(NavigationItem $item): void
     protected function containsOnlyDocumentationPages(): bool
     {
         return count($this->getItems()) && collect($this->getItems())->every(function (NavigationItem $child): bool {
-            return (! $child->getRoute() instanceof ExternalRoute) && $child->getRoute()->getPage() instanceof DocumentationPage;
+            return ($child->getRoute() !== null) && $child->getRoute()->getPage() instanceof DocumentationPage;
         });
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ protected function addItem(NavigationItem $item): void`
`79`	`79`	`protected function containsOnlyDocumentationPages(): bool`
`80`	`80`	`{`
`81`	`81`	`return count($this->getItems()) && collect($this->getItems())->every(function (NavigationItem $child): bool {`
`82`		`- return (! $child->getRoute() instanceof ExternalRoute) && $child->getRoute()->getPage() instanceof DocumentationPage;`
	`82`	`+ return ($child->getRoute() !== null) && $child->getRoute()->getPage() instanceof DocumentationPage;`
`83`	`83`	`});`
`84`	`84`	`}`
`85`	`85`	`}`