Skip to content

Commit 8e18ff4

Browse files
committed
Inline GeneratesDocumentationSidebarMenu::handle method
1 parent 84bec87 commit 8e18ff4

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

packages/framework/src/Foundation/Providers/NavigationServiceProvider.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
use Hyde\Foundation\HydeKernel;
88
use Illuminate\Support\ServiceProvider;
99
use Hyde\Framework\Features\Navigation\NavigationManager;
10+
use Hyde\Framework\Features\Navigation\DocumentationSidebar;
11+
use Hyde\Framework\Features\Navigation\NavigationMenuGenerator;
1012
use Hyde\Framework\Features\Navigation\GeneratesMainNavigationMenu;
1113
use Hyde\Framework\Features\Navigation\GeneratesDocumentationSidebarMenu;
1214

@@ -22,7 +24,7 @@ public function register(): void
2224

2325
$this->app->make(HydeKernel::class)->booted(function () {
2426
$this->app->make(NavigationManager::class)->registerMenu('main', GeneratesMainNavigationMenu::handle());
25-
$this->app->make(NavigationManager::class)->registerMenu('sidebar', GeneratesDocumentationSidebarMenu::handle());
27+
$this->app->make(NavigationManager::class)->registerMenu('sidebar', NavigationMenuGenerator::handle(DocumentationSidebar::class));
2628
});
2729
}
2830
}

packages/framework/src/Framework/Features/Navigation/DocumentationSidebar.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class DocumentationSidebar extends NavigationMenu
1818
/** @deprecated Will be moved to an action */
1919
public static function create(): static
2020
{
21-
return GeneratesDocumentationSidebarMenu::handle();
21+
return NavigationMenuGenerator::handle(DocumentationSidebar::class);
2222
}
2323

2424
public function hasGroups(): bool

packages/framework/src/Framework/Features/Navigation/GeneratesDocumentationSidebarMenu.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,5 @@
99
*/
1010
class GeneratesDocumentationSidebarMenu
1111
{
12-
public static function handle(): DocumentationSidebar
13-
{
14-
return NavigationMenuGenerator::handle(DocumentationSidebar::class);
15-
}
12+
//
1613
}

packages/framework/tests/Feature/AutomaticNavigationConfigurationsTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818
use Illuminate\Support\Collection;
1919
use Hyde\Foundation\Kernel\RouteCollection;
2020
use Hyde\Framework\Features\Navigation\NavItem;
21+
use Hyde\Framework\Features\Navigation\DocumentationSidebar;
22+
use Hyde\Framework\Features\Navigation\NavigationMenuGenerator;
2123
use Hyde\Framework\Features\Navigation\GeneratesMainNavigationMenu;
2224
use Hyde\Framework\Features\Navigation\GeneratesDocumentationSidebarMenu;
2325

@@ -1246,7 +1248,7 @@ class AssertableNavigationMenu
12461248
public function __construct(TestCase $test, $sidebar = false)
12471249
{
12481250
$this->items = $sidebar
1249-
? GeneratesDocumentationSidebarMenu::handle()->getItems()
1251+
? NavigationMenuGenerator::handle(DocumentationSidebar::class)->getItems()
12501252
: GeneratesMainNavigationMenu::handle()->getItems();
12511253

12521254
$this->test = $test;

0 commit comments

Comments
 (0)