Let the generator parse navigation items instead of the loader

We "lose" out on the null defaults, but they don't offer any value anyways.

Author: emmadesilva

packages/framework/src/Foundation/Internal/LoadYamlConfiguration.php

@@ -6,7 +6,6 @@
 
 use Throwable;
 use Illuminate\Support\Arr;
-use Hyde\Facades\Navigation;
 use Hyde\Foundation\Application;
 use Illuminate\Config\Repository;
 use Hyde\Framework\Features\Blogging\Models\PostAuthor;
@@ -52,10 +51,6 @@ protected function mergeParsedConfiguration(): void
                 $data['authors'] = $this->parseAuthors($data['authors']);
             }
 
-            if ($namespace === 'hyde' && isset($data['navigation']['custom'])) {
-                $data['navigation']['custom'] = $this->parseNavigationItems($data['navigation']['custom']);
-            }
-
             $this->mergeConfiguration($namespace, Arr::undot($data ?: []));
         }
     }
@@ -82,24 +77,4 @@ protected function parseAuthors(array $authors): array
             }
         });
     }
-
-    /**
-     * @experimental Since the main configuration also uses arrays, the only thing this method really does is to rethrow any exceptions.
-     *
-     * @param  array<array{destination: string, label: ?string, priority: ?int, attributes: array<string, scalar>}>  $items  Where destination is a route key or an external URI.
-     * @return array<array{destination: string, label: ?string, priority: ?int, attributes: array<string, scalar>}>
-     */
-    protected function parseNavigationItems(array $items): array
-    {
-        return Arr::map($items, function (array $item): array {
-            try {
-                return Navigation::item(...$item);
-            } catch (Throwable $exception) {
-                throw new InvalidConfigurationException(
-                    'Invalid navigation item configuration detected the configuration file. Please double check the syntax.',
-                    previous: $exception
-                );
-            }
-        });
-    }
 }

packages/framework/tests/Feature/YamlConfigurationFeatureTest.php

@@ -501,17 +501,14 @@ public function testCanSetCustomNavigationItemsInTheYamlConfig()
                 'destination' => 'https://example.com',
                 'label' => 'Example',
                 'priority' => 100,
-                'attributes' => [],
             ], [
                 'destination' => 'about',
                 'label' => 'About Us',
                 'priority' => 200,
-                'attributes' => [],
             ], [
                 'destination' => 'contact',
                 'label' => 'Contact',
                 'priority' => 300,
-                'attributes' => [],
             ],
         ], $configItems);
 
@@ -615,9 +612,6 @@ public function testOnlyNeedToAddDestinationToYamlConfiguredNavigationItems()
         $this->assertSame([
             [
                 'destination' => 'about.html',
-                'label' => null,
-                'priority' => null,
-                'attributes' => [],
             ],
         ], $configItems);
 
@@ -675,6 +669,7 @@ public function testTypeErrorsInNavigationYamlConfigAreRethrownMoreHelpfully()
 
         try {
             $this->runBootstrappers();
+            NavigationMenuGenerator::handle(MainNavigationMenu::class)->getItems()->all();
         } catch (InvalidConfigurationException $exception) {
             $exceptionThrown = true;
             $this->assertSame('Invalid navigation item configuration detected the configuration file. Please double check the syntax.', $exception->getMessage());
@@ -697,6 +692,7 @@ public function testMustAddDestinationToYamlConfiguredNavigationItems()
 
         try {
             $this->runBootstrappers();
+            NavigationMenuGenerator::handle(MainNavigationMenu::class)->getItems()->all();
         } catch (InvalidConfigurationException $exception) {
             $exceptionThrown = true;
             $this->assertSame('Invalid navigation item configuration detected the configuration file. Please double check the syntax.', $exception->getMessage());
@@ -720,6 +716,7 @@ public function testAddingExtraYamlNavigationItemFieldsThrowsAnException()
 
         try {
             $this->runBootstrappers();
+            NavigationMenuGenerator::handle(MainNavigationMenu::class)->getItems()->all();
         } catch (InvalidConfigurationException $exception) {
             $exceptionThrown = true;
             $this->assertSame('Invalid navigation item configuration detected the configuration file. Please double check the syntax.', $exception->getMessage());