Manually proxy and deprecate legacy facade methods

This is so we can get an overview of the outdated methods that are inconsistently named

This means they are lost from the HydeKernel which could be a problem to review before merge.

Author: emmadesilva

docs/_data/partials/hyde-pages-api/hyde-kernel-filesystem-methods.md

@@ -1,7 +1,7 @@
 <section id="hyde-kernel-filesystem-methods">
 
 <!-- Start generated docs for Hyde\Foundation\Concerns\ForwardsFilesystem -->
-<!-- Generated by HydePHP DocGen script at 2024-07-26 14:30:44 in 0.13ms -->
+<!-- Generated by HydePHP DocGen script at 2024-07-26 15:15:12 in 0.09ms -->
 
 #### `filesystem()`
 
@@ -27,22 +27,6 @@ No description provided.
 Hyde::vendorPath(string $path, string $package): string
 ```
 
-#### `mediaPath()`
-
-No description provided.
-
-```php
-Hyde::mediaPath(string $path): string
-```
-
-#### `siteMediaPath()`
-
-No description provided.
-
-```php
-Hyde::siteMediaPath(string $path): string
-```
-
 #### `sitePath()`
 
 No description provided.

packages/framework/src/Foundation/Concerns/ForwardsFilesystem.php

@@ -28,16 +28,6 @@ public function vendorPath(string $path = '', string $package = 'framework'): st
         return $this->filesystem->vendorPath($path, $package);
     }
 
-    public function mediaPath(string $path = ''): string
-    {
-        return $this->filesystem->mediaPath($path);
-    }
-
-    public function siteMediaPath(string $path = ''): string
-    {
-        return $this->filesystem->siteMediaPath($path);
-    }
-
     public function sitePath(string $path = ''): string
     {
         return $this->filesystem->sitePath($path);

packages/framework/src/Foundation/Kernel/Filesystem.php

@@ -7,7 +7,6 @@
 use Hyde\Hyde;
 use Hyde\Foundation\HydeKernel;
 use Hyde\Foundation\PharSupport;
-use Hyde\Support\Filesystem\MediaFile;
 use Illuminate\Support\Collection;
 
 use function collect;
@@ -92,22 +91,6 @@ public function pathToRelative(string $path): string
             : $path);
     }
 
-    /**
-     * Get the absolute path to the media source directory, or a file within it.
-     */
-    public function mediaPath(string $path = ''): string
-    {
-        return MediaFile::sourcePath($path);
-    }
-
-    /**
-     * Get the absolute path to the compiled site's media directory, or a file within it.
-     */
-    public function siteMediaPath(string $path = ''): string
-    {
-        return MediaFile::outputPath($path);
-    }
-
     /**
      * Get the absolute path to the compiled site directory, or a file within it.
      */

packages/framework/src/Hyde.php

@@ -34,8 +34,6 @@
  * @method static string pathToAbsolute(string $path)
  * @method static string pathToRelative(string $path)
  * @method static string sitePath(string $path = '')
- * @method static string mediaPath(string $path = '')
- * @method static string siteMediaPath(string $path = '')
  * @method static string formatLink(string $destination)
  * @method static string relativeLink(string $destination)
  * @method static string mediaLink(string $destination, bool $validate = false)

packages/framework/src/Support/V1Compatibility.php

@@ -4,12 +4,33 @@
 
 namespace Hyde\Support;
 
+use JetBrains\PhpStorm\Deprecated;
+use Hyde\Support\Filesystem\MediaFile;
+
 /**
  * @internal Hyde Facade support to aid in the v1 to v2 transition.
  *
  * @deprecated All code here is deprecated, and exists to help you transition.
  */
 trait V1Compatibility
 {
-    //
+    /**
+     * @deprecated Use MediaFile::sourcePath() instead.
+     * @see \Hyde\Support\Filesystem\MediaFile::sourcePath()
+     */
+    #[Deprecated(reason: 'Use MediaFile::sourcePath() instead', replacement: '\Hyde\Support\Filesystem\MediaFile::sourcePath()')]
+    public static function mediaPath(string $path = ''): string
+    {
+        return MediaFile::sourcePath($path);
+    }
+
+    /**
+     * @deprecated Use MediaFile::outputPath() instead.
+     * @see \Hyde\Support\Filesystem\MediaFile::outputPath()
+     */
+    #[Deprecated(reason: 'Use MediaFile::outputPath() instead', replacement: '\Hyde\Support\Filesystem\MediaFile::outputPath()')]
+    public static function siteMediaPath(string $path = ''): string
+    {
+        return MediaFile::outputPath($path);
+    }
 }