Remove the validate parameter from the mediaLink method

Author: emmadesilva

docs/_data/partials/hyde-pages-api/hyde-kernel-hyperlink-methods.md

@@ -1,7 +1,7 @@
 <section id="hyde-kernel-hyperlink-methods">
 
 <!-- Start generated docs for Hyde\Foundation\Concerns\ForwardsHyperlinks -->
-<!-- Generated by HydePHP DocGen script at 2024-07-26 18:20:22 in 0.13ms -->
+<!-- Generated by HydePHP DocGen script at 2024-07-26 18:57:46 in 0.11ms -->
 
 #### `formatLink()`
 
@@ -24,7 +24,7 @@ Hyde::relativeLink(string $destination): string
 No description provided.
 
 ```php
-Hyde::mediaLink(string $destination, bool $validate): string
+Hyde::mediaLink(string $destination): string
 ```
 
 #### `asset()`

packages/framework/src/Foundation/Concerns/ForwardsHyperlinks.php

@@ -23,9 +23,9 @@ public function relativeLink(string $destination): string
         return $this->hyperlinks->relativeLink($destination);
     }
 
-    public function mediaLink(string $destination, bool $validate = false): string
+    public function mediaLink(string $destination): string
     {
-        return $this->hyperlinks->mediaLink($destination, $validate);
+        return $this->hyperlinks->mediaLink($destination);
     }
 
     public function asset(string $name): string

packages/framework/src/Foundation/Kernel/Hyperlinks.php

@@ -93,9 +93,9 @@ public function relativeLink(string $destination): string
      * An exception will be thrown if the file does not exist in the _media directory,
      * and the second argument is set to true.
      */
-    public function mediaLink(string $destination, bool $validate = false): string
+    public function mediaLink(string $destination): string
     {
-        if ($validate && ! file_exists($sourcePath = "{$this->kernel->getMediaDirectory()}/$destination")) {
+        if (false && ! file_exists($sourcePath = "{$this->kernel->getMediaDirectory()}/$destination")) {
             throw new FileNotFoundException($sourcePath);
         }
 

packages/framework/src/Support/V1Compatibility.php

@@ -37,8 +37,8 @@ public static function siteMediaPath(string $path = ''): string
         return MediaFile::outputPath($path);
     }
 
-    public static function mediaLink(string $destination, bool $validate = false): string
+    public static function mediaLink(string $destination): string
     {
-        return HydeKernel::getInstance()->mediaLink($destination, $validate);
+        return HydeKernel::getInstance()->mediaLink($destination);
     }
 }

packages/framework/tests/Feature/Foundation/HyperlinksTest.php

@@ -7,7 +7,6 @@
 use Hyde\Foundation\HydeKernel;
 use Hyde\Foundation\Facades\Routes;
 use Hyde\Foundation\Kernel\Hyperlinks;
-use Hyde\Framework\Exceptions\FileNotFoundException;
 use Hyde\Hyde;
 use Hyde\Testing\TestCase;
 
@@ -105,16 +104,15 @@ public function testMediaLinkHelperUsesConfiguredMediaDirectory()
         $this->assertSame('assets/foo', $this->class->mediaLink('foo'));
     }
 
-    public function testMediaLinkHelperWithValidationAndExistingFile()
+    public function testMediaLinkHelperWithExistingFile()
     {
         $this->file('_media/foo');
-        $this->assertSame('media/foo', $this->class->mediaLink('foo', true));
+        $this->assertSame('media/foo', $this->class->mediaLink('foo'));
     }
 
-    public function testMediaLinkHelperWithValidationAndNonExistingFile()
+    public function testMediaLinkHelperWithNonExistingFile()
     {
-        $this->expectException(FileNotFoundException::class);
-        $this->class->mediaLink('foo', true);
+        $this->assertSame('media/foo', $this->class->mediaLink('foo'));
     }
 
     public function testRouteHelper()