Update NavigationItemTest.php

emmadesilva · emmadesilva · commit 5b5040bbca77 · 2024-03-24T12:48:01.000+01:00
diff --git a/packages/framework/tests/Unit/NavigationItemTest.php b/packages/framework/tests/Unit/NavigationItemTest.php
@@ -68,6 +68,7 @@ public function testPassingRouteKeyToConstructorUsesRouteInstance()
 
     public function testPassingUrlToConstructorUsesExternalRoute()
     {
+        $this->markTestSkipped('Todo: Reimplement this test for https://github.com/hydephp/develop/pull/1636');
         $item = new NavigationItem('https://example.com', 'Home');
         $this->assertInstanceOf(ExternalRoute::class, $item->getRoute());
         $this->assertEquals(new ExternalRoute('https://example.com'), $item->getRoute());
@@ -76,6 +77,7 @@ public function testPassingUrlToConstructorUsesExternalRoute()
 
     public function testPassingUnknownRouteKeyToConstructorUsesExternalRoute()
     {
+        $this->markTestSkipped('Todo: Reimplement this test for https://github.com/hydephp/develop/pull/1636');
         $item = new NavigationItem('foo', 'Home');
         $this->assertInstanceOf(ExternalRoute::class, $item->getRoute());
         $this->assertEquals(new ExternalRoute('foo'), $item->getRoute());

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@ public function testPassingRouteKeyToConstructorUsesRouteInstance()`
`68`	`68`
`69`	`69`	`public function testPassingUrlToConstructorUsesExternalRoute()`
`70`	`70`	`{`
	`71`	`+ $this->markTestSkipped('Todo: Reimplement this test for https://github.com/hydephp/develop/pull/1636');`
`71`	`72`	`$item = new NavigationItem('https://example.com', 'Home');`
`72`	`73`	`$this->assertInstanceOf(ExternalRoute::class, $item->getRoute());`
`73`	`74`	`$this->assertEquals(new ExternalRoute('https://example.com'), $item->getRoute());`
`@@ -76,6 +77,7 @@ public function testPassingUrlToConstructorUsesExternalRoute()`
`76`	`77`
`77`	`78`	`public function testPassingUnknownRouteKeyToConstructorUsesExternalRoute()`
`78`	`79`	`{`
	`80`	`+ $this->markTestSkipped('Todo: Reimplement this test for https://github.com/hydephp/develop/pull/1636');`
`79`	`81`	`$item = new NavigationItem('foo', 'Home');`
`80`	`82`	`$this->assertInstanceOf(ExternalRoute::class, $item->getRoute());`
`81`	`83`	`$this->assertEquals(new ExternalRoute('foo'), $item->getRoute());`