Move logic to instance accessor

Author: emmadesilva

packages/framework/src/Framework/Features/Navigation/GeneratesDocumentationSidebarMenu.php

@@ -6,8 +6,6 @@
 
 use Hyde\Pages\DocumentationPage;
 
-use function collect;
-
 /**
  * @experimental This class may change significantly before its release.
  *
@@ -42,16 +40,7 @@ protected function sortSidebarGroupsByLowestPriority(): void
         // we do an initial sorting here to order any groups.
 
         $this->items = $this->items->sortBy(function (NavItem $item): int {
-            return $item->hasChildren()
-                ? $this->getLowestPriorityInGroup($item)
-                : $item->getPriority();
+            return $item->getPriority();
         })->values();
     }
-
-    protected function getLowestPriorityInGroup(NavItem $item): int
-    {
-        // Todo: Could actually be moved to the NavItem accessor
-
-        return collect($item->getChildren())->min(fn (NavItem $child): int => $child->getPriority());
-    }
 }

packages/framework/src/Framework/Features/Navigation/NavItem.php

@@ -11,6 +11,7 @@
 use Stringable;
 use Hyde\Support\Models\ExternalRoute;
 
+use function collect;
 use function is_string;
 
 /**
@@ -135,9 +136,15 @@ public function getLabel(): string
 
     /**
      * Get the priority to determine the order of the navigation item.
+     *
+     * For dropdowns, this is the priority of the lowest priority child, unless the dropdown has a lower priority.
      */
     public function getPriority(): int
     {
+        if ($this->hasChildren()) {
+            return min($this->priority, collect($this->getChildren())->min(fn (NavItem $child): int => $child->getPriority()));
+        }
+
         return $this->priority;
     }
 

packages/framework/tests/Unit/NavItemTest.php

@@ -278,7 +278,7 @@ public function testDropdownFacadeWithChildren()
 
         $item = NavItem::dropdown('foo', $children);
         $this->assertSame($children, $item->getChildren());
-        $this->assertSame(999, $item->getPriority());
+        $this->assertSame(500, $item->getPriority());
     }
 
     public function testDropdownFacadeWithCustomPriority()