Update constructor to use the same logic as the static create method

emmadesilva · emmadesilva · commit 3979fa804983 · 2024-03-26T17:44:06.000+01:00
diff --git a/packages/framework/tests/Unit/NavigationItemTest.php b/packages/framework/tests/Unit/NavigationItemTest.php
@@ -51,11 +51,12 @@ public function testPassingRouteInstanceToConstructorUsesRouteInstance()
         $this->assertEquals($route, (new NavigationItem($route, 'Home'))->getPage()->getRoute());
     }
 
-    public function testPassingRouteKeyToConstructorUsesDestinationAsLink()
+    public function testPassingRouteKeyToConstructorUsesDestinationAsRoute()
     {
         $item = new NavigationItem('index', 'Home');
-        $this->assertNull($item->getPage());
-        $this->assertSame('index', $item->getLink());
+        $this->assertSame(Routes::get('index')->getPage(), $item->getPage());
+        $this->assertSame('index', $item->getPage()->getRouteKey());
+        $this->assertSame('index.html', $item->getLink());
     }
 
     public function testPassingUrlToConstructorSetsRouteToNull()

Original file line number	Diff line number	Diff line change
`@@ -51,11 +51,12 @@ public function testPassingRouteInstanceToConstructorUsesRouteInstance()`
`51`	`51`	`$this->assertEquals($route, (new NavigationItem($route, 'Home'))->getPage()->getRoute());`
`52`	`52`	`}`
`53`	`53`
`54`		`- public function testPassingRouteKeyToConstructorUsesDestinationAsLink()`
	`54`	`+ public function testPassingRouteKeyToConstructorUsesDestinationAsRoute()`
`55`	`55`	`{`
`56`	`56`	`$item = new NavigationItem('index', 'Home');`
`57`		`- $this->assertNull($item->getPage());`
`58`		`- $this->assertSame('index', $item->getLink());`
	`57`	`+ $this->assertSame(Routes::get('index')->getPage(), $item->getPage());`
	`58`	`+ $this->assertSame('index', $item->getPage()->getRouteKey());`
	`59`	`+ $this->assertSame('index.html', $item->getLink());`
`59`	`60`	`}`
`60`	`61`
`61`	`62`	`public function testPassingUrlToConstructorSetsRouteToNull()`