Change "category" to "group" in PublishViewsCommand

Fixes #2142

Author: emmadesilva

RELEASE_NOTES.md

@@ -54,6 +54,7 @@ This serves two purposes:
 - **Breaking:** The custom navigation item configuration now uses array inputs instead of the previous format. For more information, see the upgrade guide below.
 - **Breaking:** Renamed the `hyde.navigation.subdirectories` configuration option to `hyde.navigation.subdirectory_display`.
 - **Breaking:** Renamed the `hyde.enable_cache_busting` configuration option to `hyde.cache_busting` in https://github.com/hydephp/develop/pull/1980
+- Renamed the parameter `category` to `group` in the `publish:views` command in https://github.com/hydephp/develop/pull/2142
 - Dependency: Upgraded from Laravel 10 to Laravel 11
 - Dependency: Updated minimum PHP requirement to 8.2
 - Dependency: Updated Symfony/yaml to ^7.0

docs/getting-started/console-commands.md

@@ -222,16 +222,16 @@ Publish one of the default homepages as `index.blade.php`.
 <a name="publish-views" style="display: inline-block; position: absolute; margin-top: -5rem;"></a>
 
 ```bash
-php hyde publish:views [<category>]
+php hyde publish:views [<group>]
 ```
 
 Publish the hyde components for customization. Note that existing files will be overwritten.
 
 #### Arguments
 
-|            |                         |
-|------------|-------------------------|
-| `category` | The category to publish |
+|          |                       |
+|----------|-------------------------|
+| `group`  | The group to publish |
 
 ## Display All Registered Routes.
 

packages/framework/src/Console/Commands/PublishViewsCommand.php

@@ -25,7 +25,7 @@
 class PublishViewsCommand extends Command
 {
     /** @var string */
-    protected $signature = 'publish:views {category? : The category to publish}';
+    protected $signature = 'publish:views {group? : The group to publish}';
 
     /** @var string */
     protected $description = 'Publish the Hyde components for customization. Note that existing files will be overwritten';
@@ -40,10 +40,10 @@ public function handle(): int
             ViewPublishGroup::fromGroup('hyde-components', 'Blade Components', 'More or less self contained components, extracted for customizability and DRY code'),
         ]);
 
-        $selected = ($this->argument('category') ?? $this->promptForCategory()) ?: 'all';
+        $selected = ($this->argument('group') ?? $this->promptForGroup()) ?: 'all';
 
-        if ($selected !== 'all' && (bool) $this->argument('category') === false && ConsoleHelper::canUseLaravelPrompts($this->input)) {
-            $this->infoComment(sprintf('Selected category [%s]', $selected));
+        if ($selected !== 'all' && (bool) $this->argument('group') === false && ConsoleHelper::canUseLaravelPrompts($this->input)) {
+            $this->infoComment(sprintf('Selected group [%s]', $selected));
         }
 
         if (! in_array($selected, $allowed = array_merge(['all'], array_keys($this->options)), true)) {
@@ -64,22 +64,22 @@ public function handle(): int
         return Command::SUCCESS;
     }
 
-    protected function promptForCategory(): string
+    protected function promptForGroup(): string
     {
         SelectPrompt::fallbackUsing(function (SelectPrompt $prompt): string {
             return $this->choice($prompt->label, $prompt->options, $prompt->default);
         });
 
         return $this->parseChoiceIntoKey(
-            select('Which category do you want to publish?', $this->formatPublishableChoices(), 0) ?: 'all'
+            select('Which group do you want to publish?', $this->formatPublishableChoices(), 0) ?: 'all'
         );
     }
 
     protected function formatPublishableChoices(): array
     {
         return collect($this->options)
             ->map(fn (ViewPublishGroup $option, string $key): string => sprintf('<comment>%s</comment>: %s', $key, $option->description))
-            ->prepend('Publish all categories listed below')
+            ->prepend('Publish all groups listed below')
             ->values()
             ->all();
     }

packages/framework/tests/Feature/Commands/PublishViewsCommandTest.php

@@ -30,8 +30,8 @@ public function testCommandPublishesViews()
             + Filesystem::findFiles('vendor/hyde/framework/resources/views/layouts', '.blade.php', true)->count();
 
         $this->artisan('publish:views')
-            ->expectsQuestion('Which category do you want to publish?', 'all')
-            ->doesntExpectOutputToContain('Selected category')
+            ->expectsQuestion('Which group do you want to publish?', 'all')
+            ->doesntExpectOutputToContain('Selected group')
             ->expectsOutput("Published all $count files to [resources/views/vendor/hyde]")
             ->assertExitCode(0);
 
@@ -76,7 +76,7 @@ public function testCanSelectGroupWithQuestion()
         ConsoleHelper::disableLaravelPrompts();
 
         $this->artisan('publish:views')
-            ->expectsQuestion('Which category do you want to publish?', '<comment>layouts</comment>: Shared layout views, such as the app layout, navigation menu, and Markdown page templates')
+            ->expectsQuestion('Which group do you want to publish?', '<comment>layouts</comment>: Shared layout views, such as the app layout, navigation menu, and Markdown page templates')
             ->expectsOutput('Published all [layout] files to [resources/views/vendor/hyde/layouts]')
             ->assertExitCode(0);
 
@@ -213,8 +213,8 @@ public function testCanSelectGroupWithQuestionAndPrompts()
         }
 
         $this->artisan('publish:views')
-            ->expectsQuestion('Which category do you want to publish?', '<comment>layouts</comment>: Shared layout views, such as the app layout, navigation menu, and Markdown page templates')
-            ->expectsOutput('Selected category [layouts]')
+            ->expectsQuestion('Which group do you want to publish?', '<comment>layouts</comment>: Shared layout views, such as the app layout, navigation menu, and Markdown page templates')
+            ->expectsOutput('Selected group [layouts]')
             ->expectsQuestion('Select the files you want to publish', [(is_dir(Hyde::path('packages')) ? 'packages' : 'vendor/hyde').'/framework/resources/views/layouts/app.blade.php'])
             ->expectsOutput('Published selected file to [resources/views/vendor/hyde/layouts/app.blade.php]')
             ->assertExitCode(0);
@@ -229,7 +229,7 @@ public function testCanSelectGroupWithQuestionAndPrompts()
     protected function executePublishViewsCommand(): BufferedOutput
     {
         $command = (new PublishViewsCommand());
-        $input = new ArrayInput(['category' => 'layouts'], $command->getDefinition());
+        $input = new ArrayInput(['group' => 'layouts'], $command->getDefinition());
         $output = new BufferedOutput();
         $command->setInput($input);
         $command->setOutput(new OutputStyle($input, $output));