Remove type check for old class

emmadesilva · emmadesilva · commit 22da970c31a6 · 2024-03-24T15:36:34.000+01:00
diff --git a/packages/framework/src/Framework/Features/Navigation/NavigationItem.php b/packages/framework/src/Framework/Features/Navigation/NavigationItem.php
@@ -64,7 +64,7 @@ public static function create(Route|string $destination, ?string $label = null,
             $destination = Routes::get($destination);
         }
 
-        if ($destination instanceof Route && ! $destination instanceof ExternalRoute) {
+        if ($destination instanceof Route) {
             return new self(
                 $destination,
                 $label ?? $destination->getPage()->navigationMenuLabel(),

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public static function create(Route\|string $destination, ?string $label = null,`
`64`	`64`	`$destination = Routes::get($destination);`
`65`	`65`	`}`
`66`	`66`
`67`		`- if ($destination instanceof Route && ! $destination instanceof ExternalRoute) {`
	`67`	`+ if ($destination instanceof Route) {`
`68`	`68`	`return new self(`
`69`	`69`	`$destination,`
`70`	`70`	`$label ?? $destination->getPage()->navigationMenuLabel(),`