Deprecate dropdown accessors in new class

emmadesilva · emmadesilva · commit 1df963693c34 · 2024-02-14T16:30:47.000+01:00
diff --git a/packages/framework/src/Framework/Features/Navigation/NavigationMenu.php b/packages/framework/src/Framework/Features/Navigation/NavigationMenu.php
@@ -25,12 +25,23 @@ public function getItems(): Collection
         return $this->items;
     }
 
+    /**
+     * @experimental These do not seem to be used outside of tests and may be removed
+     *
+     * @deprecated If kept, they should be renamed to be more generic.
+     */
     public function hasDropdowns(): bool
     {
         return $this->dropdownsEnabled() && count($this->getDropdowns()) >= 1;
     }
 
-    /** @return array<string, DropdownNavItem> */
+    /**
+     * @experimental These do not seem to be used outside of tests and may be removed
+     *
+     * @deprecated If kept, they should be renamed to be more generic.
+     *
+     * @return array<string, DropdownNavItem>
+     */
     public function getDropdowns(): array
     {
         if (! $this->dropdownsEnabled()) {

Original file line number	Diff line number	Diff line change
`@@ -25,12 +25,23 @@ public function getItems(): Collection`
`25`	`25`	`return $this->items;`
`26`	`26`	`}`
`27`	`27`
	`28`	`+ /**`
	`29`	`+ * @experimental These do not seem to be used outside of tests and may be removed`
	`30`	`+ *`
	`31`	`+ * @deprecated If kept, they should be renamed to be more generic.`
	`32`	`+ */`
`28`	`33`	`public function hasDropdowns(): bool`
`29`	`34`	`{`
`30`	`35`	`return $this->dropdownsEnabled() && count($this->getDropdowns()) >= 1;`
`31`	`36`	`}`
`32`	`37`
`33`		`- /** @return array<string, DropdownNavItem> */`
	`38`	`+ /**`
	`39`	`+ * @experimental These do not seem to be used outside of tests and may be removed`
	`40`	`+ *`
	`41`	`+ * @deprecated If kept, they should be renamed to be more generic.`
	`42`	`+ *`
	`43`	`+ * @return array<string, DropdownNavItem>`
	`44`	`+ */`
`34`	`45`	`public function getDropdowns(): array`
`35`	`46`	`{`
`36`	`47`	`if (! $this->dropdownsEnabled()) {`