Register virtual routes through the service container

Author: emmadesilva

packages/realtime-compiler/src/RealtimeCompilerServiceProvider.php

@@ -4,6 +4,7 @@
 
 namespace Hyde\RealtimeCompiler;
 
+use Desilva\Microserve\JsonResponse;
 use Illuminate\Support\ServiceProvider;
 
 class RealtimeCompilerServiceProvider extends ServiceProvider
@@ -17,6 +18,8 @@ public function register(): void
 
     public function boot(): void
     {
-        //
+        $this->app->make(RealtimeCompiler::class)->registerVirtualRoute('/ping', new JsonResponse(200, 'OK', [
+            'server' => 'Hyde/RealtimeCompiler',
+        ]));
     }
 }

packages/realtime-compiler/src/Routing/Router.php

@@ -7,6 +7,7 @@
 use Desilva\Microserve\JsonResponse;
 use Desilva\Microserve\Request;
 use Desilva\Microserve\Response;
+use Hyde\RealtimeCompiler\RealtimeCompiler;
 use Hyde\RealtimeCompiler\Actions\AssetFileLocator;
 use Hyde\RealtimeCompiler\Concerns\SendsErrorResponses;
 use Hyde\RealtimeCompiler\Models\FileObject;
@@ -20,13 +21,6 @@ class Router
 
     protected Request $request;
 
-    /**
-     * @deprecated This should be moved to the container.
-     */
-    protected array $virtualRoutes = [
-        '/ping',
-    ];
-
     public function __construct(Request $request)
     {
         $this->request = $request;
@@ -40,12 +34,10 @@ public function handle(): Response
 
         $this->bootApplication();
 
-        if (in_array($this->request->path, $this->virtualRoutes)) {
-            if ($this->request->path === '/ping') {
-                return new JsonResponse(200, 'OK', [
-                    'server' => 'Hyde/RealtimeCompiler',
-                ]);
-            }
+        $virtualRoutes = app(RealtimeCompiler::class)->getVirtualRoutes();
+
+        if (isset($virtualRoutes[$this->request->path])) {
+            return $virtualRoutes[$this->request->path];
         }
 
         return PageRouter::handle($this->request);