Update post author name to fall back to username at construct time

Author: emmadesilva

packages/framework/src/Framework/Features/Blogging/Models/PostAuthor.php

@@ -53,7 +53,7 @@ class PostAuthor implements Stringable, SerializableContract
     public function __construct(string $username, ?string $name = null, ?string $website = null)
     {
         $this->username = $username;
-        $this->name = $name;
+        $this->name = $name ?? $username;
         $this->website = $website;
     }
 
@@ -99,7 +99,7 @@ public function toArray(): array
 
     public function getName(): string
     {
-        return $this->name ?? $this->username;
+        return $this->name;
     }
 
     /** @param array{username?: string, name?: string, website?: string} $data */

packages/framework/tests/Feature/HydeKernelTest.php

@@ -586,6 +586,7 @@ public function testAuthorsUseTheConfigArrayKey()
         $this->assertSame([
             'foo' => [
                 'username' => 'bar',
+                'name' => 'bar',
             ],
         ], Hyde::authors()->toArray());
     }

packages/framework/tests/Feature/MarkdownPostTest.php

@@ -25,7 +25,7 @@ public function testConstructorCanCreateANewAuthorInstanceFromUsernameString()
 
         $this->assertInstanceOf(PostAuthor::class, $post->author);
         $this->assertSame('John Doe', $post->author->username);
-        $this->assertNull($post->author->name);
+        $this->assertSame('John Doe', $post->author->name);
         $this->assertNull($post->author->website);
     }
 

packages/framework/tests/Unit/PostAuthorTest.php

@@ -41,6 +41,13 @@ public function testCanCreateAuthorModelWithDetails()
         $this->assertSame('https://example.com', $author->website);
     }
 
+    public function testNameIsSetToUsernameIfNoNameIsProvided()
+    {
+        $author = new PostAuthor('foo');
+
+        $this->assertSame('foo', $author->name);
+    }
+
     public function testCreateMethodCreatesNewAuthorModel()
     {
         $author = Author::create('foo');
@@ -218,6 +225,6 @@ public function testEmptyFieldsAreRemovedFromSerializedModel()
     {
         $author = new PostAuthor('username', null, null);
 
-        $this->assertSame('{"username":"username"}', $author->toJson());
+        $this->assertSame('{"username":"username","name":"username"}', $author->toJson());
     }
 }